remove old ifdef'd code from

Hi.

I'm not attaching this inline, it's 80k and might make someone unhappy. 4 patches are at: http://coderock.org/kernel/janitor/old_ifdefs_scsi-gdth/

Comments?

Domen

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors

On Mon, 17 May 2004 14:44:49 +0200 Domen Puncer wrote:

| Hi.
| 
| I'm not attaching this inline, it's 80k and might make someone unhappy.
| 4 patches are at: http://coderock.org/kernel/janitor/old_ifdefs_scsi-gdth/
| 
| Comments?

They look OK to me. A couple of small items:

If I were doing these (not saying that this is any kind of requirement :), I would add:

a. 'diffstat -p1' output
b. comments like "I built and loaded it. Don't have hardware
to test it."

It might be a good idea to check the init and exit sections for mis-use with something like:
http://developer.osdl.org/rddunlap/scripts/reference_init26.pl
and report that also.

Or in general just report what you have done in order to have some confidence in these (any) patches. (This is meant to be a general comment, not directed at Domen in particular.)

--
~Randy

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors

Hi Domen,

Current -mm already contains a maintainer update that does part of your cleanup with the exception that kernel 2.2 support should stay in the driver...

cu
Adrian

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors