Skip to contentSkip to conversation

efivars: add MODULE_VERSION, remove unnecessary check in exit

DISCUSSION Matt Domsch 1 participant 1 message May 17, 2004

lore
Share & tools
lore
#0 lore raw

* Adds MODULE_VERSION
* Remove check for efi_enabled in efivars_exit() - we aborted module load at init based on this already.

Signature · 56 lines
Matt Domsch
Sr. Software Engineer, Lead Engineer
Dell Linux Solutions linux.dell.com & www.dell.com/linux
Linux on Dell mailing lists @ http://lists.us.dell.com


===== drivers/firmware/efivars.c 1.4 vs edited =====
--- 1.4/drivers/firmware/efivars.c	Sat May 15 01:11:54 2004
+++ edited/drivers/firmware/efivars.c	Mon May 17 14:38:25 2004
@@ -23,6 +23,10 @@
  *
  * Changelog:
  *
+ *  17 May 2004 - Matt Domsch <[email protected]>
+ *   remove check for efi_enabled in exit
+ *   add MODULE_VERSION
+ *
  *  26 Apr 2004 - Matt Domsch <[email protected]>
  *   minor bug fixes
  *
@@ -77,11 +81,13 @@
 
 #include <asm/uaccess.h>
 
+#define EFIVARS_VERSION "0.08"
+#define EFIVARS_DATE "2004-May-17"
+
 MODULE_AUTHOR("Matt Domsch <[email protected]>");
 MODULE_DESCRIPTION("sysfs interface to EFI Variables");
 MODULE_LICENSE("GPL");
-
-#define EFIVARS_VERSION "0.07 2004-Apr-26"
+MODULE_VERSION(EFIVARS_VERSION);
 
 /*
  * efivars_lock protects two things:
@@ -667,7 +673,8 @@
 	if (!efi_enabled)
 		return -ENODEV;
 
-	printk(KERN_INFO "EFI Variables Facility v%s\n", EFIVARS_VERSION);
+	printk(KERN_INFO "EFI Variables Facility v%s %s\n", EFIVARS_VERSION,
+	       EFIVARS_DATE);
 
 	/*
 	 * For now we'll register the efi subsys within this driver
@@ -735,9 +742,6 @@
 efivars_exit(void)
 {
 	struct list_head *pos, *n;
-
-	if (!efi_enabled)
-		return;
 
 	list_for_each_safe(pos, n, &efivar_list)
 		efivar_unregister(get_efivar_entry(pos));