Incomplete AT24RF08 corruption prevention in i2c eeprom
PATCH 1/1 Incomplete AT24RF08 corruption prevention in i2c eeprom
Hi Greg,
The AT24RF08 corruption prevention trick that is found in the i2c eeprom driver is not correct. The prevention is activated only conditionally, while it should be done all the time.
Please apply,
thanks.
drivers/i2c/chips/eeprom.c renamed from drivers/i2c/chips/eeprom.c.orig +3 -2
@@ -203,11 +203,12 @@ new_client->driver = &eeprom_driver; new_client->flags =0 ; +/* prevent 24RF08 corruption */ +i2c_smbus_write_quick (new_client,0 ); +/* Now, we do the remaining detection. It is not there, unless you force the checksum to work out. */ if (checksum) { -/* prevent 24RF08 corruption */ -i2c_smbus_write_quick (new_client,0 ); cs =0 ;for (i =0 ; i <=0x3e ; i++) cs +=i2c_smbus_read_byte_data (new_client, i);
Signature · 2 lines
Jean Delvare http://khali.linux-fr.org/
Greg KH
AppliedPATCH 1/1 Incomplete AT24RF08 corruption prevention in i2c
Quoted 5 lines · Jean Delvare
Hi Greg,
The AT24RF08 corruption prevention trick that is found in the i2c eeprom driver is not correct. The prevention is activated only conditionally, while it should be done all the time.
Applied, thanks.
greg k-h