Skip to contentSkip to conversation

RFC: filenames without periods in isofs

PATCH Christoph Hellwig 1 participant 1 message May 22, 2004

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

currently isofs marks filenames witout periods as executable which is rather odd. The Debian kernel package has an old patch to sanitize this behaviour and I wonder whether we should get it into mainline.

* Removed period check for executables in fs/isofs/inode.c

fs/isofs/inode.c +0 -8
@@ -1250,14 +1250,6 @@
 		inode->i_mode = sbi->s_mode;
 		inode->i_nlink = 1;
 	        inode->i_mode |= S_IFREG;
-		/* If there are no periods in the name,
-		 * then set the execute permission bit
-		 */
-		for(i=0; i< de->name_len[0]; i++)
-			if(de->name[i]=='.' || de->name[i]==';')
-				break;
-		if(i == de->name_len[0] || de->name[i] == ';')
-			inode->i_mode |= S_IXUGO; /* execute permission */
 	}
 	inode->i_uid = sbi->s_uid;
 	inode->i_gid = sbi->s_gid;