emu10k1x patch
A few minor fixes to the emu10k1x driver. Also, it would be nice to update the soundcards page to list it as supported (mention that only PCM playback is currently supported).
I will try to test a few more things before 1.0.5 gets final, I hope.
Francisco
Index: pci/emu10k1/emu10k1x.c
===================================================================
RCS file: /cvsroot/alsa/alsa-driver/pci/emu10k1/emu10k1x.c,v retrieving revision 1.2
diff -r1.2 emu10k1x.c
185c185
< .channels_min = 1,
---
Quoted 1 line
.channels_min = 2,
188,189c188,189
< .period_bytes_min = 64, < .period_bytes_max = (32*1024),
---
Quoted 2 lines
.period_bytes_min = (16*1024),
.period_bytes_max = (16*1024),732,733c732,733
< // snd_emu10k1x_intr_enable(chip, (INTE_CH_0_LOOP<<1); < // snd_emu10k1x_intr_enable(chip, INTE_CH_0_LOOP<<2);
---
Quoted 1 line
snd_emu10k1x_intr_enable(chip, (INTE_CH_0_LOOP|INTE_CH_0_HALF_LOOP)<<1);> snd_emu10k1x_intr_enable(chip, (INTE_CH_0_LOOP|INTE_CH_0_HALF_LOOP)<<2);
At Tue, 25 May 2004 01:00:58 GMT,
Quoted 7 lines · [email protected] wrote:
188,189c188,189
< .period_bytes_min = 64, < .period_bytes_max = (32*1024),---
Quoted 2 lines
.period_bytes_min = (16*1024), .period_bytes_max = (16*1024),
are you sure this change is correct?
in the current code, the period size is always bound to (buffer_size / 2) (because periods_min = periods_max = 2). so you don't have to limit period_bytes or period_size.
Quoted 5 lines
732,733c732,733
< // snd_emu10k1x_intr_enable(chip, (INTE_CH_0_LOOP<<1); < // snd_emu10k1x_intr_enable(chip, INTE_CH_0_LOOP<<2);---
Quoted 1 line
snd_emu10k1x_intr_enable(chip, (INTE_CH_0_LOOP|INTE_CH_0_HALF_LOOP)<<1);> snd_emu10k1x_intr_enable(chip, (INTE_CH_0_LOOP|INTE_CH_0_HALF_LOOP)<<2);
hmm, it looks redundant.
the second line will override the setting of the first line. i guess you wanted like the following?
snd_emu10k1x_intr_enable(chip, (INTE_CH_0_LOOP|INTE_CH_0_HALF_LOOP)<<1 | (INTE_CH_0_LOOP|INTE_CH_0_HALF_LOOP)<<2);
Takashi
-------------------------------------------------------
This SF.Net email is sponsored by: Oracle 10g
Get certified on the hottest thing ever to hit the market... Oracle 10g. Take an Oracle 10g class now, and we'll give you the exam FREE.
http://ads.osdn.com/?ad_id=3149&alloc_id=8166&op=click