Skip to contentSkip to conversation

kjt patch-set for 2.6.7-rc1

Kernel-janitors Domen Puncer 2 participants 2 messages May 24, 2004 Kernel janitors

lore
Share & tools
lore
#0 lore raw
Quoted 2 lines · maximilian attems

hello!

Hi.

...

Quoted 4 lines

this patch is intended for further _testing_ of our work. i hope that it helps Acme releasing the official kj ones. i won't forward anything to maintainers or lkml. will try to release on weekly/10days base.

...

Great idea!

I have one suggestion, try egrep -n "^\+(.* $| )", to see if
patches introduce trailing spaces or spaces instead of tabs. This also bit me, so below are links to 2 updated patches.

Quoted 1 line

+remove-old-ifdefs-fasttimer

http://coderock.org/kernel/janitor/old_ifdefs-take3/arch-cris-arch-v10-kernel-fasttimer.c_take2

Quoted 1 line

+remove-old-ifdefs-mtdcore

http://coderock.org/kernel/janitor/old_ifdefs-take3/drivers-mtd-mtdcore.c_take2

Review

Quoted 3 lines
(quoted diff) +3 -0
+yield-nicedelay-sb1000
+yield-schedtmout-megaraid
+yield-schedtmout-sonycd535

These are the other patches that contain spaces.

Domen

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors

#1 lore raw

On Mon, 24 May 2004, Domen Puncer wrote:

..

Quoted 5 lines

Great idea!

I have one suggestion, try egrep -n "^\+(.* $| )", to see if
patches introduce trailing spaces or spaces instead of tabs. This also bit me, so below are links to 2 updated patches.

thanks for your nice feedback and hints,
for the next releases i'll check the patches.

Quoted 9 lines
Quoted 1 line

+remove-old-ifdefs-fasttimer

http://coderock.org/kernel/janitor/old_ifdefs-take3/arch-cris-arch-v10-kernel-fasttimer.c_take2

Quoted 1 line

+remove-old-ifdefs-mtdcore

http://coderock.org/kernel/janitor/old_ifdefs-take3/drivers-mtd-mtdcore.c_take2

Review

Quoted 3 lines
(quoted diff) +3 -0
+yield-nicedelay-sb1000
+yield-schedtmout-megaraid
+yield-schedtmout-sonycd535

These are the other patches that contain spaces.

yours weren't run with '-p' diff switch (-> SubmittingPatches ;) for now i've handedited those, didn't see further spaces, patch a bit smaller now and lot cleaner!!!

great
a++ maks

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors