Skip to contentSkip to conversation

suspend2 problems on SMP machine, incorrect tainting

DISCUSSION Pavel Machek 2 participants 5 messages May 28, 2004 – May 29, 2004

lore
Share & tools
lore
#0 lore raw

Hi!

I tried suspend2 2.0.0.81 on Toshiba HT machine, and it did not work :-(. First test was with "noapic nosmp", last messages are

Message from syslogd@elonex...
elonex kernel: - I/O speed: Write 80 MB/s, Read 83 MB/s

Unable to handle kernel NULL pointer deference at virtual address 100

...
EIP: c13f7f81 (<- outside of kernel symbols?! strange) Tainted: G S
...
(no call trace, strange).

Tainted: S is due to suspend2, right? It abuses flag that origally means

"invalid SMP configuration". You might want to fix that.

Tried without noapic nosmp... display got "interesting" at one point, but hey, it worked! I have "sleeping function called rom invalid context at arch/i386/mm/highmem.c:5" called from kmap, copy_pageset1.

Tried "noapic" only, worked ok.

Signature · 1 line
934a471f20d6580d5aad759bf0d97ddc
#1 lore raw

Hi.

Quoted 4 lines · Pavel Machek

Hi!

I tried suspend2 2.0.0.81 on Toshiba HT machine, and it did not work :-(. First test was with "noapic nosmp", last messages are

Hmm. I haven't tried it with noapic or nosmp options before. It ought to work; I'll see if I can reproduce this issue.

Quoted 2 lines
Tainted: S is due to suspend2, right? It abuses flag that origally means

"invalid SMP configuration". You might want to fix that.

Yes. I've been meaning to change that; must get around to it.

Quoted 1 line

Tried without noapic nosmp... display got "interesting" at one point,

Yes. The sequence of operations to force a redraw of the screen works okay under 2.4 but needs looking at under 2.6.

Quoted 2 lines

but hey, it worked! I have "sleeping function called rom invalid context at arch/i386/mm/highmem.c:5" called from kmap, copy_pageset1.

Yes. It needs to be atomic (it's the atomic copy) and pages might well be HighMem so I guess the answer is to suppress the message rather than changing something in suspend.

Nigel

Signature · 6 lines
Nigel & Michelle Cunningham
C/- Westminster Presbyterian Church Belconnen
61 Templeton Street, Cook, ACT 2614.
+61 (2) 6251 7727(wk); +61 (2) 6254 0216 (home)

After homosexuality, they'll be arguing paedophilia is normal.
#2 lore raw

Hi again.

Quoted 1 line · Nigel Cunningham

Yes. It needs to be atomic (it's the atomic copy) and pages might well be HighMem so I guess the answer is to suppress the message rather than changing something in suspend.

Before someone says it, yes. I mean using kmap_atomic :>

Nigel

Signature · 6 lines
Nigel & Michelle Cunningham
C/- Westminster Presbyterian Church Belconnen
61 Templeton Street, Cook, ACT 2614.
+61 (417) 100 574 (mobile)

After homosexuality, they'll be arguing paedophilia is normal.
#3 lore raw
In reply to Pavel Machek

Hi again.

I should mention that the code is not perfectly stable at the moment. As soon as it is I'll get stuck into last cleanups and then the merge. Crashes I'm seeing involve an oops shortly after resuming, occuring in slab code. Obviously an inconsistency has somehow sneaked in. I'm away from home for 8 days from Monday AM, so a fix won't be forthcoming this week. It shouldn't be far away though.

Regards,

Nigel

Signature · 6 lines
Nigel & Michelle Cunningham
C/- Westminster Presbyterian Church Belconnen
61 Templeton Street, Cook, ACT 2614.
+61 (2) 6251 7727(wk); +61 (2) 6254 0216 (home)

After homosexuality, they'll be arguing paedophilia is normal.
#4 lore raw

Hi!

Quoted 4 lines

I should mention that the code is not perfectly stable at the moment. As soon as it is I'll get stuck into last cleanups and then the merge. Crashes I'm seeing involve an oops shortly after resuming, occuring in slab code.

The oops I saw with "nosmp noapic" was after resuming... it might be related.
Pavel

Signature · 1 line
934a471f20d6580d5aad759bf0d97ddc