Skip to contentSkip to conversation

i2c-piix: Don't treat ServerWorks servers as Laptops

PATCH New Vojtech Pavlik 4 participants 8 messages May 19, 2005

Subsystems (2)
I2C subsystem host drivers I2C/smbus controller drivers for pc
lore
Share & tools
lore

Vojtech Pavlik

author
#0 lore raw

PATCH 1/1 i2c-piix: Don't treat ServerWorks servers as Laptops

Hi!

I'm sending you this little obvious patch which should enable i2c-piix to work on IBM servers with ServerWorks chipsets. It still will treat any IBM/Intel machine as a laptop and refuse to work, but it's better than before.

[email protected], 2004-03-19 16:01:20+01:00, [email protected]
i2c: Treat only IBM machines with Intel chipsets as IBM laptops.

 i2c-piix4.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)
drivers/i2c/busses/i2c-piix4.c +1 -1
diff -Nru a/drivers/i2c/busses/i2c-piix4.c b/drivers/i2c/busses/i2c-piix4.c
@@ -138,7 +138,7 @@
 
 	dev_info(&PIIX4_dev->dev, "Found %s device\n", pci_name(PIIX4_dev));
 
-	if(ibm_dmi_probe()) {
+	if(ibm_dmi_probe() && PIIX4_dev->vendor = PCI_VENDOR_ID_INTEL) {
 		dev_err(&PIIX4_dev->dev, "IBM Laptop detected; this module "
 			"may corrupt your serial eeprom! Refusing to load "
 			"module!\n");
Signature · 2 lines
Vojtech Pavlik
SuSE Labs, SuSE CR
author
#1 lore raw

PATCH 1/1 i2c-piix: Don't treat ServerWorks servers as Laptops

Quoted 8 lines · Jean Delvare
Quoted 4 lines

I'm sending you this little obvious patch which should enable i2c-piix to work on IBM servers with ServerWorks chipsets. It still will treat any IBM/Intel machine as a laptop and refuse to work, but it's better than before.

Fine with me. Note that the whole thing will hopefully disappear soon in 2.6 anyway. OTOH a similar "fix" would be welcome for 2.4 since I don't plan to to the big change there.

It should patch against 2.4 quite easily, too.

Signature · 2 lines
Vojtech Pavlik
SuSE Labs, SuSE CR
#2 lore raw

PATCH 1/1 i2c-piix: Don't treat ServerWorks servers as Laptops

In reply to Vojtech Pavlik
Quoted 4 lines

I'm sending you this little obvious patch which should enable i2c-piix to work on IBM servers with ServerWorks chipsets. It still will treat any IBM/Intel machine as a laptop and refuse to work, but it's better than before.

Fine with me. Note that the whole thing will hopefully disappear soon in 2.6 anyway. OTOH a similar "fix" would be welcome for 2.4 since I don't plan to to the big change there.

Thanks.

Signature · 2 lines
Jean Delvare
http://khali.linux-fr.org/
author
#3 lore raw

PATCH 1/1 i2c-piix: Don't treat ServerWorks servers as Laptops

In reply to Vojtech Pavlik
Quoted 1 line · Mark Studebaker

you're sure that there are no serverworks chips in IBM laptops?

Quite sure, yes. There's no checking for any other non-intel chipsets either, and the chance isn't bigger than for example a SiS chipset being in an IBM laptop.

Quoted 13 lines
Quoted 12 lines · Vojtech Pavlik
Quoted 8 lines · Jean Delvare
Quoted 4 lines

I'm sending you this little obvious patch which should enable i2c-piix to work on IBM servers with ServerWorks chipsets. It still will treat any IBM/Intel machine as a laptop and refuse to work, but it's better than before.

Fine with me. Note that the whole thing will hopefully disappear soon in 2.6 anyway. OTOH a similar "fix" would be welcome for 2.4 since I don't plan to to the big change there.

It should patch against 2.4 quite easily, too.

Signature · 2 lines
Vojtech Pavlik
SuSE Labs, SuSE CR
author
#4 lore raw

PATCH 1/1 i2c-piix: Don't treat ServerWorks servers as Laptops

In reply to Vojtech Pavlik
Quoted 2 lines · Mark Studebaker

thanks.
I checked it into CVS.

Thanks.

Signature · 2 lines
Vojtech Pavlik
SuSE Labs, SuSE CR
Applied
#5 lore raw

PATCH 1/1 i2c-piix: Don't treat ServerWorks servers as Laptops

In reply to Vojtech Pavlik
Quoted 10 lines · Vojtech Pavlik

Hi!

I'm sending you this little obvious patch which should enable i2c-piix to work on IBM servers with ServerWorks chipsets. It still will treat any IBM/Intel machine as a laptop and refuse to work, but it's better than before.

[email protected], 2004-03-19 16:01:20+01:00, [email protected]
i2c: Treat only IBM machines with Intel chipsets as IBM laptops.

Applied, thanks.

greg k-h

#6 lore raw

PATCH 1/1 i2c-piix: Don't treat ServerWorks servers as Laptops

In reply to Vojtech Pavlik

you're sure that there are no serverworks chips in IBM laptops?

Quoted 14 lines · Vojtech Pavlik
Quoted 8 lines · Jean Delvare
Quoted 4 lines

I'm sending you this little obvious patch which should enable i2c-piix to work on IBM servers with ServerWorks chipsets. It still will treat any IBM/Intel machine as a laptop and refuse to work, but it's better than before.

Fine with me. Note that the whole thing will hopefully disappear soon in 2.6 anyway. OTOH a similar "fix" would be welcome for 2.4 since I don't plan to to the big change there.

It should patch against 2.4 quite easily, too.

#7 lore raw

PATCH 1/1 i2c-piix: Don't treat ServerWorks servers as Laptops

In reply to Vojtech Pavlik

thanks.
I checked it into CVS.

Quoted 28 lines · Vojtech Pavlik
Quoted 1 line · Mark Studebaker

you're sure that there are no serverworks chips in IBM laptops?

Quite sure, yes. There's no checking for any other non-intel chipsets either, and the chance isn't bigger than for example a SiS chipset being in an IBM laptop.

Quoted 15 lines
Quoted 13 lines · Vojtech Pavlik
Quoted 8 lines · Jean Delvare
Quoted 4 lines

I'm sending you this little obvious patch which should enable i2c-piix to work on IBM servers with ServerWorks chipsets. It still will treat any IBM/Intel machine as a laptop and refuse to work, but it's better than before.

Fine with me. Note that the whole thing will hopefully disappear soon in 2.6 anyway. OTOH a similar "fix" would be welcome for 2.4 since I don't plan to to the big change there.

It should patch against 2.4 quite easily, too.