Lowered priority of "too many keys" message in atkbd
PATCH 1/1 Lowered priority of "too many keys" message in atkbd
This patch is from the Debian kernel package and I think it's valid because this error doesn't cause any kind of malfunction of the system.
drivers/input/keyboard/atkbd.c +1 -1
@@ -284,7 +284,7 @@atkbd_report_key (&atkbd->dev, regs,KEY_HANJA ,3 ); goto out;case ATKBD_RET_ERR : -printk (KERN_WARNING "atkbd.c: Keyboard on %s reports too many keys pressed.\n" , serio->phys); +printk (KERN_DEBUG "atkbd.c: Keyboard on %s reports too many keys pressed.\n" , serio->phys); goto out; }
Hi!
Quoted 3 lines
This patch is from the Debian kernel package and I think it's valid because this error doesn't cause any kind of malfunction of the system.
Except perhaps dropped key?
When keypress is lost, I like to know if my fingers are to blame, keyboard hardware is to blame, or keyboard is misdesigned.
Pavel
Quoted 11 lines
drivers/input/keyboard/atkbd.c +1
-1@@ -284,7 +284,7 @@atkbd_report_key (&atkbd->dev, regs,KEY_HANJA ,3 ); goto out;case ATKBD_RET_ERR : -printk (KERN_WARNING "atkbd.c: Keyboard on %s reports too many keys pressed.\n" , serio->phys); +printk (KERN_DEBUG "atkbd.c: Keyboard on %s reports too many keys pressed.\n" , serio->phys); goto out; }
Signature · 1 line
934a471f20d6580d5aad759bf0d97ddc
Quoted 9 lines · Pavel Machek
Quoted 4 lines
This patch is from the Debian kernel package and I think it's valid because this error doesn't cause any kind of malfunction of the system.
Except perhaps dropped key?
When keypress is lost, I like to know if my fingers are to blame, keyboard hardware is to blame, or keyboard is misdesigned.
And from experience I can tell, that lossy keyboards are a royal pain in the behind. And the system not doing *exactly* what I tell it to do *is* a malfunction of the system.
"This is bad. Do you really want to do it? (y/n)"
Just a single wrong key, eh!
Jörn
Signature · 3 lines
Fools ignore complexity. Pragmatists suffer it. Some can avoid it. Geniuses remove it. -- Perlis's Programming Proverb #58, SIGPLAN Notices, Sept. 1982