Skip to contentSkip to conversation

atiixp ac97 timeout gives error (2.6.7-rc2)

PATCH In review Ard van Breemen 2 participants 3 messages Jun 8, 2004 – Jun 13, 2004

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 atiixp ac97 timeout gives error (2.6.7-rc2)

Hi,
I found that with 2.6.7-rc2 alsa refuses to recognize my atiixp as a working sound card.
My atiixp is of a compaq nx9110 notebook.

pci stuff:

0000:00:14.5 Class 0401: 1002:4341

        Subsystem: 103c:006b
        Flags: bus master, 66MHz, slow devsel, latency 64, IRQ 5
        Memory at d0003000 (32-bit, non-prefetchable)

or:
0000:00:14.5 Multimedia audio controller: ATI Technologies Inc SoundMAX Integrated Digital Audio

I've patched the atiixp driver by ignoring the error when the driver loads. If I recall correctly, this was the normal behaviour in 2.6.5: a timeout warning was issued, but the "card" functioned is it should.

If an alsa developer could point me to the "right" way, I can make the patch a real patch.

atiixp.c renamed from atiixp.c.org +9 -3
@@ -1387,12 +1387,18 @@
 		ac97.num = i;
 		ac97.scaps = AC97_SCAP_SKIP_MODEM;
 		if ((err = snd_ac97_mixer(pbus, &ac97, &chip->ac97[i])) < 0) {
-			if (chip->codec_not_ready_bits)
+
+	 		if (chip->codec_not_ready_bits) {
 				/* codec(s) was detected but not available.
 				 * return the error
 				 */
-				return err;
-			else {
+				/*
+				 * The codec probably still is busy, which is
+				 * according to specs I thought.
+				 */
+				/* return err; */
+				printk("snd-atiixp: ignored codec not ready\n",__LINE__);
+			} else {
 				/* codec(s) was NOT detected, so just ignore here */
 				chip->ac97[i] = NULL; /* to be sure */
 				snd_printd("atiixp: codec %d not found\n", i);
#1 lore raw

At Tue, 8 Jun 2004 13:16:22 +0200,

Quoted 16 lines · Ard van Breemen

Hi,
I found that with 2.6.7-rc2 alsa refuses to recognize my atiixp as a working sound card.
My atiixp is of a compaq nx9110 notebook.

pci stuff:

0000:00:14.5 Class 0401: 1002:4341

        Subsystem: 103c:006b
        Flags: bus master, 66MHz, slow devsel, latency 64, IRQ 5
        Memory at d0003000 (32-bit, non-prefetchable)

or:
0000:00:14.5 Multimedia audio controller: ATI Technologies Inc SoundMAX Integrated Digital Audio

Quoted 7 lines

I've patched the atiixp driver by ignoring the error when the driver loads. If I recall correctly, this was the normal behaviour in 2.6.5: a timeout warning was issued, but the "card" functioned is it should.

If an alsa developer could point me to the "right" way, I can make the patch a real patch.

It's already fixed in the mm tree. Please give a try.

Takashi

#2 lore raw
Quoted 5 lines · Takashi Iwai

At Tue, 8 Jun 2004 13:16:22 +0200,

Quoted 1 line · Ard van Breemen

I've patched the atiixp driver by ignoring the error when the

It's already fixed in the mm tree. Please give a try.

Yes, it works. Thanks. Now I also understand what happens :-).