let VIDEO_ZORAN depend on I2C_ALGOBIT
PATCH 1/1 let VIDEO_ZORAN depend on I2C_ALGOBIT
The following compile error occurs with VIDEO_ZORAN=y and I2C_ALGOBIT=n in 2.6.7-mm1 (but it's not specific to -mm):
<-- snip -->
LD .tmp_vmlinux1
drivers/built-in.o(.text+0x3861d3): In function `zoran_register_i2c':
: undefined reference to i2c_bit_add_bus' drivers/built-in.o(.text+0x3861e9): In function zoran_unregister_i2c':
: undefined reference to `i2c_bit_del_bus'
make: *** [.tmp_vmlinux1] Error 1
<-- snip -->
The following patch fixes this issue:
drivers/media/video/Kconfig renamed from drivers/media/video/Kconfig.old +1 -1
@@ -155,7 +155,7 @@ config VIDEO_ZORAN tristate "Zoran ZR36057/36067 Video For Linux" - depends on VIDEO_DEV && PCI && I2C + depends on VIDEO_DEV && PCI && I2C_ALGOBIT help Say Y for support for MJPEG capture cards based on the Zoran 36057/36067 PCI controller chipset. This includes the Iomega
cu
Adrian
Signature · 4 lines
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon SeedHi Adrian,
Quoted 2 lines · Adrian Bunk
The following compile error occurs with VIDEO_ZORAN=y and I2C_ALGOBIT=n in 2.6.7-mm1 (but it's not specific to -mm):
[..]
Quoted 1 line
The following patch fixes this issue:
[..]
Thanks, I'll take care of sending this upstream. I think that you're currently required to "sign off" a patch when you sent it over to maintainers. See e.g. http://www.linuxdevices.com/news/NS3012318028.html
for details. It's really as simple as including a line "Signed-off-by: Random J Developer <[email protected]>" in your patch email. See http://kerneltrap.org/node/view/3180 for details and Linus' initial email.
Thanks,
Ronald