Skip to contentSkip to conversation

drivers/media/video/bt832.c: ACK return on

PATCH New Arthur Othieno 2 participants 3 messages May 19, 2005 Media (V4L/DVB)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drivers/media/video/bt832.c: ACK return on

Hi,

i2c_add_driver() may actually fail, but this driver returns 0 regardless. Against 2.6.7. Thanks.

 bt832.c |    7 +++----
 1 files changed, 3 insertions(+), 4 deletions(-)
drivers/media/video/bt832.c +3 -4
@@ -255,13 +255,12 @@ static struct i2c_client client_template
 };
 
 
-int bt832_init_module(void)
+static int __init bt832_init_module(void)
 {
-	i2c_add_driver(&driver);
-	return 0;
+	return i2c_add_driver(&driver);
 }
 
-static void bt832_cleanup_module(void)
+static void __exit bt832_cleanup_module(void)
 {
 	i2c_del_driver(&driver);
 }
#1 lore raw

PATCH 1/1 drivers/media/video/bt832.c: ACK return on

Hi Arthur,

Quoted 2 lines

i2c_add_driver() may actually fail, but this driver returns 0 regardless. Against 2.6.7. Thanks.

Your patches look good, but we do not have the possibility to apply them ourselves. You should direct your requests to the drivers maintainers (as you did for some of the patches). If you can't find who this is, please try the media/video subsystem maintainer (if there is one). Else I guess you can fallback to Greg KH since this is i2c stuff.

At any rate, please realize that any of these patches, sent only to the lm_sensors mailing list, will be lost unless you redirect them to the correct person.

Thanks,
Jean Delvare

#2 lore raw

PATCH 1/1 drivers/media/video/bt832.c: ACK return on

In reply to Arthur Othieno
Quoted 6 lines · Jean Delvare

Your patches look good, but we do not have the possibility to apply them ourselves. You should direct your requests to the drivers maintainers (as you did for some of the patches). If you can't find who this is, please try the media/video subsystem maintainer (if there is one). Else I guess you can fallback to Greg KH since this is i2c stuff.

Quoted 6 lines

At any rate, please realize that any of these patches, sent only to the lm_sensors mailing list, will be lost unless you redirect them to the correct person.

Thanks,
Jean Delvare

Eeek! And I was using (keeping) the wrong address in the Cc: and To:
fields all along. So this is what happens when you miss that daily dose of caffeine.

Apologies for the noise.

Arthur