Skip to contentSkip to conversation

drivers/media/video/ir-kbd-i2c.c: ACK return on

PATCH New Arthur Othieno 1 participant 1 message May 19, 2005 Media (V4L/DVB)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drivers/media/video/ir-kbd-i2c.c: ACK return on

Hi,

i2c_add_driver() may actually fail, but this driver returns 0 regardless. Against 2.6.7. Thanks.

 ir-kbd-i2c.c |    7 +++----
 1 files changed, 3 insertions(+), 4 deletions(-)
drivers/media/video/ir-kbd-i2c.c +3 -4
@@ -388,13 +388,12 @@ MODULE_AUTHOR("Gerd Knorr, Michal Kochan
 MODULE_DESCRIPTION("input driver for i2c IR remote controls");
 MODULE_LICENSE("GPL");
 
-static int ir_init(void)
+static int __init ir_init(void)
 {
-	i2c_add_driver(&driver);
-	return 0;
+	return i2c_add_driver(&driver);
 }
 
-static void ir_fini(void)
+static void __exit ir_fini(void)
 {
 	i2c_del_driver(&driver);
 }