drivers/media/video/saa7134/saa6752.c: ACK return on

PATCH New Arthur Othieno 1 participant 1 message May 19, 2005 Media (V4L/DVB)

lore

Share & tools

lore

Arthur Othieno

author

2005-05-19 06:25 UTC #0 lore raw

PATCH 1/1 drivers/media/video/saa7134/saa6752.c: ACK return on

Hi,

i2c_add_driver() may actually fail, but this driver returns 0 regardless. Against 2.6.7. Thanks.

Signed-off-by Arthur Othieno <[email protected]>

 saa6752hs.c |    7 +++----
 1 files changed, 3 insertions(+), 4 deletions(-)

drivers/media/video/saa7134/saa6752hs.c +3 -4

@@ -388,13 +388,12 @@ static struct i2c_client client_template
         .driver     = &driver,
 };
 
-static int saa6752hs_init_module(void)
+static int __init saa6752hs_init_module(void)
 {
-	i2c_add_driver(&driver);
-	return 0;
+	return i2c_add_driver(&driver);
 }
 
-static void saa6752hs_cleanup_module(void)
+static void __exit saa6752hs_cleanup_module(void)
 {
 	i2c_del_driver(&driver);
 }