Bug fix in mm/hugetlb.c - use safe iterater

PATCH Chen, Kenneth W 1 participant 1 message Jun 22, 2004

Subsystems (2)

Memory management HugeTLB

lore

Share & tools

lore

Chen, Kenneth W

author

2004-06-22 21:02 UTC #0 lore raw

With list poisoning on by default from linux-2.6.7, it's easier than ever to trigger the bug in try_to_free_low(). It ought to use the safe version of list iterater.

Signed-off-by Ken Chen <[email protected]>

mm/hugetlb.c +2 -2

diff -Nurp linux-2.6.7.orig/mm/hugetlb.c linux-2.6.7/mm/hugetlb.c
@@ -134,8 +134,8 @@ static int try_to_free_low(unsigned long
 {
 	int i;
 	for (i = 0; i < MAX_NUMNODES; ++i) {
-		struct page *page;
-		list_for_each_entry(page, &hugepage_freelists[i], lru) {
+		struct page *page, *next;
+		list_for_each_entry_safe(page, next, &hugepage_freelists[i], lru) {
 			if (PageHighMem(page))
 				continue;
 			list_del(&page->lru);