Skip to contentSkip to conversation

Fragmented SCSI disk messages in 2.6.7

PATCH New Chuck Ebbert 1 participant 1 message Jun 23, 2004 SCSI

lore
Share & tools
lore

Chuck Ebbert

author
#0 lore raw

PATCH 1/1 Fragmented SCSI disk messages in 2.6.7

Without this patch I get the following on bootup with media inserted in a USB powered Zip 250:

sda: Spinning up disk....<6>EXT3 FS on hde3, internal journal Adding 524152k swap on /dev/hdg2. Priority:-1 extents:1 Adding 524152k swap on /dev/hde2. Priority:-2 extents:1 .<6>kjournald starting. Commit interval 5 seconds (( --- Snip 17 lines of EXT3 mount messages --- )) ..<3>microcode: error! Bad data in microcode data file
microcode: Error in the microcode data
.....ready

Signed-off-by Chuck Ebbert <[email protected]>
drivers/scsi/sd.c 2004-06-21 16:25:12.464827752 -0400 renamed from drivers/scsi/sd.c 2004-06-21 16:09:58.099832360 -0400 +3 -4
@@ -889,7 +889,7 @@ sd_spinup_disk(struct scsi_disk *sdkp, c
                } else if (SRpnt->sr_sense_buffer[2] == NOT_READY) {
                        unsigned long time1;
                        if (!spintime) {
-                               printk(KERN_NOTICE "%s: Spinning up disk...",
+                               printk(KERN_NOTICE "%s: Spinning up disk...\n",
                                       diskname);
                                cmd[0] = START_STOP;
                                cmd[1] = 1;     /* Return immediately */

@@ -912,7 +912,6 @@ sd_spinup_disk(struct scsi_disk *sdkp, c
                                current->state = TASK_UNINTERRUPTIBLE;
                                time1 = schedule_timeout(time1);
                        } while(time1);
-                       printk(".");
                } else {
                        /* we don't understand the sense code, so it's
                         * probably pointless to loop */

@@ -928,9 +927,9 @@ sd_spinup_disk(struct scsi_disk *sdkp, c
 
        if (spintime) {
                if (scsi_status_is_good(the_result))
-                       printk("ready\n");
+                       printk(KERN_NOTICE "%s: Disk ready\n", diskname);
                else
-                       printk("not responding...\n");
+                       printk(KERN_NOTICE "%s: Disk not responding...\n", diskname);
        }
 }