Skip to contentSkip to conversation

mlmmj-0.8.1

DISCUSSION Mads Martin Joergensen 1 participant 2 messages Jun 25, 2004 – Jun 27, 2004

lore
Share & tools
lore
#0 lore raw

Hey people,

It's time for another version, since we cannot be nesting bugfixes and nice features :)

The ChangeLog has it:

0.8.1
o Go through all open() calls and retry in case we (allthough it's extremely unlikely) did get EEXIST
o Add the option to add a To: header including the recipient emailaddress. NOTE that this does not remove any existing To: headers, they should be removed in control/delheaders
o Optimize mlmmj-send by preparing the mail in memory to reduce the amount of write syscalls. control/memmailsize (size in bytes) controls how big it can be. Default is 16k before it's send line by line.
o Make sure we check if the Subject: prefix might be present in the de-quoted printable version of the Subject. If so, don't add it.
o Fix bug with queuefilename not being correctly initialized when generating standard mails
o Let mlmmj-send be capable of handling relayhost local users bounce probes bouncing.
o Don't litter the queuedirectory with files when rejecting mails (the maintenance daemon would take care of it, but lets be nice)

Signature · 4 lines
Mads Martin Joergensen, http://mmj.dk
"Why make things difficult, when it is possible to make them cryptic
 and totally illogical, with just a little bit more effort?"
                                -- A. P. J.
#1 lore raw
Quoted 3 lines · Mads Martin Joergensen

0.8.1
o Go through all open() calls and retry in case we (allthough it's extremely unlikely) did get EEXIST

This caused a nasty bug to appear in the function preparing standard replies. Apply this patch or just grab mlmmj-0.8.1.1.

src/prepstdreply.c +3 -4
@@ -64,18 +64,17 @@
 	myfree(tmp);
 
 	do {
-                tmp = random_str();
+		tmp = random_str();
 		myfree(retstr);
 		retstr = concatstr(3, listdir, "/queue/", tmp);
 		myfree(tmp);
 
-                outfd = open(filename, O_RDWR|O_CREAT|O_EXCL,
-				       S_IRUSR|S_IWUSR);
+		outfd = open(retstr, O_RDWR|O_CREAT|O_EXCL, S_IRUSR|S_IWUSR);
 
 	} while ((outfd < 0) && (errno = EEXIST));
 	
 	if(outfd < 0) {
-		log_error(LOG_ARGS, "Could not open std mail %s", tmp);
+		log_error(LOG_ARGS, "Could not open std mail %s", retstr);
 		myfree(str);
 		return NULL;
 	}

Thanks to Christian Laursen for finding.

Signature · 4 lines
Mads Martin Joergensen, http://mmj.dk
"Why make things difficult, when it is possible to make them cryptic
 and totally illogical, with just a little bit more effort?"
                                -- A. P. J.