Skip to contentSkip to conversation

signed bug in net/decnet/dn_nsp_in.c dn_nsp_linkservice()

PATCH New Olaf Hering 1 participant 1 message Jun 28, 2004

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 signed bug in net/decnet/dn_nsp_in.c dn_nsp_linkservice()

net/decnet/dn_nsp_in.c:534: warning: comparison is always false due to limited range of data type

char can be either signed or unsigned, depending on the target system. patch is against 2.6.7-bk11

net/decnet/dn_nsp_in.c +1 -1
@@ -504,7 +504,7 @@
 	struct dn_scp *scp = DN_SK(sk);
 	unsigned short segnum;
 	unsigned char lsflags;
-	char fcval;
+	signed char fcval;
 	int wake_up = 0;
 	char *ptr = skb->data;
 	unsigned char fctype = scp->services_rem & NSP_FC_MASK;
Signature · 3 lines
USB is for mice, FireWire is for men!

sUse lINUX ag, nÜRNBERG