Skip to contentSkip to conversation

signed bug in drivers/video/console/fbcon.c con2fb_map[]

PATCH New Olaf Hering 1 participant 1 message Jun 28, 2004

lore
Share & tools
lore

Olaf Hering

author
#0 lore raw

PATCH 1/1 signed bug in drivers/video/console/fbcon.c con2fb_map[]

drivers/video/console/fbcon.c:310: warning: comparison is always true due to limited range of data type

char can be either signed or unsigned, depending on the target system. patch is against 2.6.7-bk11

video/console/fbcon.c +1 -1
@@ -101,7 +101,7 @@
 #endif
 
 struct display fb_display[MAX_NR_CONSOLES];
-char con2fb_map[MAX_NR_CONSOLES];
+signed char con2fb_map[MAX_NR_CONSOLES];
 static int logo_height;
 static int logo_lines;
 static int logo_shown = -1;
video/console/fbcon.h +1 -1
@@ -36,7 +36,7 @@
 };
 
 /* drivers/video/console/fbcon.c */
-extern char con2fb_map[MAX_NR_CONSOLES];
+extern signed char con2fb_map[MAX_NR_CONSOLES];
 extern int set_con2fb_map(int unit, int newidx);
 
     /*
Signature · 3 lines
USB is for mice, FireWire is for men!

sUse lINUX ag, nÜRNBERG