Skip to contentSkip to conversation

remove drivers/char/h8.{c,h}

PATCH In review Adrian Bunk 2 participants 2 messages Jul 2, 2004 Char and misc drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 remove drivers/char/h8.{c,h}

Hi Richard,

I didn't get an answer regarding the following mail sent one year ago:

----- Forwarded message from Adrian Bunk <[email protected]> -----

Date: Mon, 14 Jul 2003 00:43:30 +0200
From: Adrian Bunk <[email protected]>
To: [email protected]
Cc: [email protected]
Subject: Remove CONFIG_H8 in 2.5?

CONFIG_H8 in drivers/char/ depend in both 2.4 and 2.5 on CONFIG_OBSOLETE.

Since CONFIG_OBSOLETE is never set it is not selectable.
Is there any reason why this driver should stay in the kernel or would you accept a patch that removes this driver?

cu
Adrian

----- End forwarded message -----

Since this issue is still present in current 2.6 kernels, I'd suggest the following:

rm drivers/char/h8.c
rm drivers/char/h8.h

drivers/char/Kconfig renamed from drivers/char/Kconfig.old +0 -10
@@ -795,16 +795,6 @@
 	  This option enables support for the LCD display and buttons found
 	  on Cobalt systems through a misc device.
 
-config H8
-	bool "Tadpole ANA H8 Support (OBSOLETE)"
-	depends on OBSOLETE && ALPHA_BOOK1
-	help
-	  The Hitachi H8/337 is a microcontroller used to deal with the power
-	  and thermal environment. If you say Y here, you will be able to
-	  communicate with it via a character special device.
-
-	  If unsure, say N.
-
 config DTLK
 	tristate "Double Talk PC internal speech card support"
 	help
drivers/char/Makefile renamed from drivers/char/Makefile.old +0 -1
@@ -69,7 +69,6 @@
 obj-$(CONFIG_QIC02_TAPE) += tpqic02.o
 obj-$(CONFIG_FTAPE) += ftape/
 obj-$(CONFIG_COBALT_LCD) += lcd.o
-obj-$(CONFIG_H8) += h8.o
 obj-$(CONFIG_PPDEV) += ppdev.o
 obj-$(CONFIG_NWBUTTON) += nwbutton.o
 obj-$(CONFIG_NWFLASH) += nwflash.o
#1 lore raw
Quoted 3 lines · Adrian Bunk

Since CONFIG_OBSOLETE is never set it is not selectable.
Is there any reason why this driver should stay in the kernel or would you accept a patch that removes this driver?

Kill it.

r~