Skip to contentSkip to conversation

modular swim3

PATCH In review Christoph Hellwig 3 participants 4 messages Jul 7, 2004

Subsystems (2)
Block layer Linux for power macintosh
lore
Share & tools
lore

Christoph Hellwig

author
#0 lore raw

PATCH 1/1 modular swim3

Needs one magic mediabay symbol exported. I've also moved the Kconfig entry to where it belongs.

drivers/block/Kconfig +7 -0
@@ -33,6 +33,13 @@
 	  Say Y here to support the SWIM (Super Woz Integrated Machine) IOP
 	  floppy controller on the Macintosh IIfx and Quadra 900/950.
 
+config MAC_FLOPPY
+	tristate "Support for PowerMac floppy"
+	depends on PPC_PMAC && !PPC_PMAC64
+	help
+	  If you have a SWIM-3 (Super Woz Integrated Machine 3; from Apple)
+	  floppy controller, say Y here. Most commonly found in PowerMacs.
+
 config BLK_DEV_PS2
 	tristate "PS/2 ESDI hard disk support"
 	depends on MCA && MCA_LEGACY
drivers/macintosh/Kconfig +0 -7
@@ -118,13 +118,6 @@
 	  events; also, the PowerBook button device will be enabled so you can
 	  change the screen brightness.
 
-config MAC_FLOPPY
-	bool "Support for PowerMac floppy"
-	depends on PPC_PMAC && !PPC_PMAC64
-	help
-	  If you have a SWIM-3 (Super Woz Integrated Machine 3; from Apple)
-	  floppy controller, say Y here. Most commonly found in PowerMacs.
-
 config MAC_SERIAL
 	tristate "Support for PowerMac serial ports (OBSOLETE DRIVER)"
 	depends on PPC_PMAC && BROKEN
drivers/macintosh/mediabay.c +1 -0
@@ -435,6 +435,7 @@
 #endif /* CONFIG_BLK_DEV_IDE */
 	return -ENODEV;
 }
+EXPORT_SYMBOL(check_media_bay);
 
 int __pmac check_media_bay_by_base(unsigned long base, int what)
 {
#1 lore raw
Quoted 2 lines · Christoph Hellwig

Needs one magic mediabay symbol exported. I've also moved the Kconfig entry to where it belongs.

Hrm... I wouldn't recommend anybody to try to rmmod it though ...

Ben.

author
#2 lore raw
Quoted 5 lines · Benjamin Herrenschmidt
Quoted 2 lines · Christoph Hellwig

Needs one magic mediabay symbol exported. I've also moved the Kconfig entry to where it belongs.

Hrm... I wouldn't recommend anybody to try to rmmod it though ...

it's doesn't have a module_exit() entry point, so it's unloadable anyway

#3 lore raw
In reply to Benjamin Herrenschmidt
Quoted 5 lines · Benjamin Herrenschmidt
Quoted 2 lines · Christoph Hellwig

Needs one magic mediabay symbol exported. I've also moved the Kconfig entry to where it belongs.

Hrm... I wouldn't recommend anybody to try to rmmod it though ...

This is an interesting concept, is it possible to mark a module such that it should not be removed. There have been many instances on the list where it has been said that rmmod is the enemy of stability, and so long as only modules that you need are loaded then there should not be much pressure to unload them...

Cheers,
Paul