Skip to contentSkip to conversation

ec3104: replace schedule_timeout() with

PATCH New Nishanth Aravamudan 1 participant 1 message Jul 21, 2004

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ec3104: replace schedule_timeout() with

I would appreciate any comments from the janitors list. This is one (of a few) places where I had to make a decision to set the state before the call to

schedule_timeout();

This of course affected any decision to replace the code with msleep() or not. Please inform if the other state from the one I used is desired.

Thanks,
Nish

Applys-to: 2.6.7

Description: Uses msleep() instead of schedule_timeout() to guarantee the task delays at least the desired time amount.

drivers/char/ec3104_keyb.c +1 -1
@@ -412,7 +412,7 @@ static void ec3104_keyb_clear_state(void
 	k->last_msr = 0;
 
 	for (;;) {
-		schedule_timeout(HZ/10);
+		msleep(100);
 
 		msr = ctrl_inb(EC3104_SER4_MSR);
 	

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors