corrected comments in cpu_init
PATCH 1/1 corrected comments in cpu_init
The comments in the cpu_init file (concerning the PCI memory accesses) are corrected (the PPC is _slave_ instead of _master_). In our case, the DSP is the _master_ and read/writes to the PPC memory over PCI.
-------------- next part --------------
cpu/mpc824x/cpu_init.c +5 -1
@@ -108,7 +108,7 @@CONFIG_READ_BYTE (PCMBCR ,val);/* in order not to corrupt data which is being read over the PCI bus -* with the PPC as master, we need to reduce the number of PCMRBs to 1, +* with the PPC as slave, we need to reduce the number of PCMRBs to 1, * 4.11 in the processor user manual * */
@@ -117,6 +117,10 @@#else CONFIG_WRITE_BYTE (PCMBCR ,(val|0x80 ));/* 2 PCMRBs */ CONFIG_WRITE_BYTE (PCMBCR ,(val|0x40 ));/* 3 PCMRBs */ +/* default, 4 PCMRBs are used, so don't change the +* register is this is _really_ what you want: data +* corruption with no performance gain +*/ #endif #endif
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://lists.denx.de/pipermail/u-boot/attachments/20040723/00d428fb/attachment.pgp
PATCH 1/1 corrected comments in cpu_init
Quoted 4 lines · In message <[email protected]> you wrote:
The comments in the
cpu_initfile (concerning the PCI memory accesses) are corrected (the PPC is _slave_ instead of _master_). In our case, the DSP is the _master_ and read/writes to the PPC memory over PCI.
Added, thanks.
But:
* Please provide a CHANGELOG entry netx time!
* Don't add trailing white space!
Best regards,
Wolfgang Denk
Signature · 4 lines
Software Engineering: Embedded and Realtime Systems, Embedded Linux
Phone: (+49)-8142-4596-87 Fax: (+49)-8142-4596-88 Email: wd at denx.de
You Don't Have To Be 'Damned' To Work Here, But It Helps!!!
- Terry Pratchett, _Eric_