Skip to contentSkip to conversation

eicon/platform: replace

PATCH New Nishanth Aravamudan 1 participant 2 messages Jul 23, 2004 – Jul 26, 2004 Kernel janitors

lore
Share & tools
lore

Nishanth Aravamudan

author
#0 lore raw

PATCH 1/1 eicon/platform: replace

I would appreciate any comments from the janitors list.

Thanks,
Nish

Depends-on: Patches to eicon/capifunc, io, mntfunc, os_4bri, os_bri, os_pri, which replace invocations of diva_os_sleep() and diva_os_wait() with msleep() and mdelay() respectively. Will not compile without those patches.

Applys-to: 2.6.7

Description: Replace diva_os_sleep() with msleep() and diva_os_wait() with mdelay() in all instances.

Signed-off-by Nishanth Aravamudan <[email protected]>
drivers/isdn/hardware/eicon/platform.h +0 -15
@@ -210,21 +210,6 @@ void diva_os_free_message_buffer(diva_os
 #define DIVA_MESSAGE_BUFFER_DATA(x) x->data
 
 /*
-** mSeconds waiting
-*/
-static __inline__ void diva_os_sleep(dword mSec)
-{
-	unsigned long timeout = HZ * mSec / 1000 + 1;
-
-	set_current_state(TASK_UNINTERRUPTIBLE);
-	schedule_timeout(timeout);
-}
-static __inline__ void diva_os_wait(dword mSec)
-{
-	mdelay(mSec);
-}
-
-/*
 **  PCI Configuration space access
 */
 void PCIwrite (byte bus, byte func, int offset, void* data, int length, void* pci_dev_handle);

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors

author
#1 lore raw

PATCH 1/1 eicon/platform: replace

Quoted 12 lines · Armin Schindler
Quoted 10 lines · Nishanth Aravamudan

I would appreciate any comments from the janitors list.

Thanks,
Nish

Depends-on: Patches to eicon/capifunc, io, mntfunc, os_4bri, os_bri, os_pri, which replace invocations of diva_os_sleep() and diva_os_wait() with msleep() and mdelay() respectively. Will not compile without those patches.

Quoted 8 lines

What is the reason for your patches ?

Most of the drivers code is 'common-' code, used in other OSes too. So to maintain all of this, wrapper functions like diva_os_*() make it easier and I don't like to change that.

If necessary, the inline function itself should be changed, not the main code.

I have made this change specifically. Please find the new patch below. All of the previous eicon patches can be ignored, then, and just this one applied.

Thanks,
Nish

drivers/isdn/hardware/eicon/platform.h +1 -4
@@ -214,10 +214,7 @@ void diva_os_free_message_buffer(diva_os
 */
 static __inline__ void diva_os_sleep(dword mSec)
 {
-	unsigned long timeout = HZ * mSec / 1000 + 1;
-
-	set_current_state(TASK_UNINTERRUPTIBLE);
-	schedule_timeout(timeout);
+	msleep(mSec);
 }
 static __inline__ void diva_os_wait(dword mSec)
 {

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors