isdn/hysdn_sched: replace
PATCH 1/1 isdn/hysdn_sched: replace
I would appreciate any comments from the janitors list. This is one (of many) cases where I made a decision about replacing
set_current_state(TASK_INTERRUPTIBLE);schedule_timeout(some_time);
with
msleep(jiffies_to_msecs(some_time));
msleep() is not exactly the same as the previous code, but I only did this replacement where I thought long delays were *desired*. If this is not the case here, then just disregard this patch.
Thanks,
Nish
Applys-to: 2.6.7
Description: Replace schedule_timeout() with msleep() to guarantee the task delays for the desired time.
Signed-off-by Nishanth Aravamudan <[email protected]>
drivers/isdn/hysdn/hysdn_sched.c +2 -4
@@ -160,8 +160,7 @@ hysdn_tx_cfgline(hysdn_card * card, uchaif (card->debug_flags &LOG_SCHED_ASYN )hysdn_addlog (card,"async tx-cfg delayed" ); -set_current_state (TASK_INTERRUPTIBLE ); -schedule_timeout ((20 *HZ ) /1000 );/* Timeout 20ms */ +msleep (20 );if (!--cnt) {restore_flags (flags);return (-ERR_ASYNC_TIME );/* timed out */
@@ -190,8 +189,7 @@ hysdn_tx_cfgline(hysdn_card * card, uchaif (card->debug_flags &LOG_SCHED_ASYN )hysdn_addlog (card,"async tx-cfg waiting for tx-ready" ); -set_current_state (TASK_INTERRUPTIBLE ); -schedule_timeout ((20 *HZ ) /1000 );/* Timeout 20ms */ +msleep (20 );if (!--cnt) {restore_flags (flags);return (-ERR_ASYNC_TIME );/* timed out */
_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors