isdn/isdn_tty: replace schedule_timeout()
PATCH 1/1 isdn/isdn_tty: replace schedule_timeout()
I would appreciate any comments from the janitors list. This is one (of many) cases where I made a decision about replacing
set_current_state(TASK_INTERRUPTIBLE);schedule_timeout(some_time);
with
msleep(jiffies_to_msecs(some_time));
msleep() is not exactly the same as the previous code, but I only did this replacement where I thought long delays were *desired*. If this is not the case here, then just disregard this patch.
Thanks,
Nish
Applys-to: 2.6.7
Description: Replace schedule_timeout() with msleep() to guarantee the task delays for the desired time.
Signed-off-by Nishanth Aravamudan <[email protected]>
drivers/isdn/i4l/isdn_tty.c +2 -2
@@ -13,6 +13,7 @@#include <linux/config.h> #include <linux/isdn.h> +#include <linux/delay.h> #include "isdn_common.h" #include "isdn_tty.h" #ifdef CONFIG_ISDN_AUDIO
@@ -1756,8 +1757,7 @@ isdn_tty_close(struct tty_struct *tty, s tty->closing =0 ;module_put (info->owner);if (info->blocked_open) { -set_current_state (TASK_INTERRUPTIBLE ); -schedule_timeout (HZ /2 ); +msleep (500 );wake_up_interruptible (&info->open_wait); } info->flags &= ~(ISDN_ASYNC_NORMAL_ACTIVE |ISDN_ASYNC_CLOSING );
_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors