md: replace schedule_timeout() with
Subsystems (2)
PATCH 1/1 md: replace schedule_timeout() with
I would appreciate any comments from the janitors list. This is one (of many) cases where I made a decision about replacing
set_current_state(TASK_INTERRUPTIBLE);schedule_timeout(some_time);
with
msleep(jiffies_to_msecs(some_time));
msleep() is not exactly the same as the previous code, but I only did this replacement where I thought long delays were *desired*. If this is not the case here, then just disregard this patch.
Thanks,
Nish
Applys-to: 2.6.7
Description: Use schedule_timeout() instead of msleep() to guarantee the task delays the desired time.
Signed-off-by Nishanth Aravamudan <[email protected]>
drivers/md/md.c +1 -2
@@ -3438,8 +3438,7 @@ static void md_do_sync(mddev_t *mddev)if (currspeed > sysctl_speed_limit_min) {if ((currspeed > sysctl_speed_limit_max) || !is_mddev_idle (mddev)) { - current->state =TASK_INTERRUPTIBLE ; -schedule_timeout (HZ /4 ); +msleep (250 ); goto repeat; } }
_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors