Skip to contentSkip to conversation

net/ns83820: replace

PATCH Benjamin LaHaise 2 participants 2 messages Jul 27, 2004

Subsystems (2)
Network drivers Kernel janitors
lore
Share & tools
lore

Benjamin LaHaise

author
#0 lore raw

The commit message doesn't seem correspond to the actual patch. What are you trying to "fix"?

-ben

Quoted 25 lines · Nishanth Aravamudan

I would appreciate any comments from the janitors list.

Applys-to: 2.6.7

Description: Replace schedule_timeout() with msleep() to guarantee the task delays for the desired time.

Signed-off-by Nishanth Aravamudan <[email protected]>
drivers/net/ns83820.c +1 -2
@@ -1959,7 +1959,7 @@ static int __devinit ns83820_init_one(st
 		printk(KERN_INFO "%s: resetting phy\n", ndev->name);
 		writel(dev->CFG_cache | CFG_PHY_RST, dev->base + CFG);
 		set_current_state(TASK_UNINTERRUPTIBLE);
-		schedule_timeout((HZ+99)/100);
+		schedule_timeout(10);
 		writel(dev->CFG_cache, dev->base + CFG);
 	}
 
--

To unsubscribe, send a message with 'unsubscribe linux-ns83820' in the body to [email protected].

Signature · 1 line
"Time is what keeps everything from happening all at once." -- John Wheeler

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors

#1 lore raw
Quoted 2 lines · Benjamin LaHaise

The commit message doesn't seem correspond to the actual patch. What are you trying to "fix"?

Thanks for catching this - it was another typo. Please find the corrected patch below.

-Nish

Applys-to: 2.6.7

Description: Uses msleep() instead of schedule_timeout() to guarantee the task delays the desired time.

Signed-off-by Nishanth Aravamudan <[email protected]>
drivers/net/ns83820.c +1 -2
@@ -1958,8 +1958,7 @@ static int __devinit ns83820_init_one(st
 	if (reset_phy) {
 		printk(KERN_INFO "%s: resetting phy\n", ndev->name);
 		writel(dev->CFG_cache | CFG_PHY_RST, dev->base + CFG);
-		set_current_state(TASK_UNINTERRUPTIBLE);
-		schedule_timeout((HZ+99)/100);
+		msleep(10);
 		writel(dev->CFG_cache, dev->base + CFG);
 	}

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors