wan/cosa: replace schedule_timeout() with
Subsystems (2)
PATCH 1/1 wan/cosa: replace schedule_timeout() with
I would appreciate any comments from the janitors list. This is one (of many) cases where I made a decision about replacing
set_current_state(TASK_INTERRUPTIBLE);schedule_timeout(some_time);
with
msleep(jiffies_to_msecs(some_time));
msleep() is not exactly the same as the previous code, but I only did this replacement where I thought long delays were *desired*. If this is not the case here, then just disregard this patch.
Thanks,
Nish
Applys-to: 2.6.7
Description: Replace schedule_timeout() with msleep() to guarantee the task delays for the desired time.
Signed-off-by Nishanth Aravamudan <[email protected]>
drivers/net/wan/cosa.c +1 -2
@@ -1563,8 +1563,7 @@ static int cosa_reset_and_read_id(structcosa_getdata8 (cosa);cosa_putstatus (cosa,SR_RST );#ifdef MODULE - current->state =TASK_INTERRUPTIBLE ; -schedule_timeout (HZ /2 ); +msleep (500 );#else udelay (5 *100000 );#endif
_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors