hotplug/ibmphp: remove long_delay
Subsystems (2)
PATCH 1/1 hotplug/ibmphp: remove long_delay
I would appreciate any comments from the janitors list.
Applys-to: 2.6.7
Description: Remove unused function long_delay().
drivers/pci/hotplug/ibmphp.h +0 -6
@@ -759,11 +759,5 @@ extern int ibmphp_configure_card (structextern int ibmphp_unconfigure_card (struct slot **,int );extern struct hotplug_slot_ops ibmphp_hotplug_slot_ops; -static inline void long_delay (int delay) -{ -set_current_state (TASK_INTERRUPTIBLE ); -schedule_timeout (delay); -} -#endif //__IBMPHP_H
_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors
PATCH 1/1 hotplug/ibmphp_core: replace long_delay()
I would appreciate any comments from the janitors list. This is one (of many) cases where I made a decision about replacing
set_current_state(TASK_INTERRUPTIBLE);schedule_timeout(some_time);
with
msleep(jiffies_to_msecs(some_time));
msleep() is not exactly the same as the previous code, but I only did this replacement where I thought long delays were *desired*. If this is not the case here, then just disregard this patch.
Thanks,
Nish
Applys-to: 2.6.7
Description: Replace long_delay() with msleep() to guarantee the task delays as desired.
drivers/pci/hotplug/ibmphp_core.c +2 -2
@@ -190,7 +190,7 @@ static inline int power_on (struct sloterr ("command not completed successfully in power_on\n" );return -EIO ; } -long_delay (3 *HZ );/* For ServeRAID cards, and some 66 PCI */ +msleep (3000 );return 0 ; }
@@ -913,7 +913,7 @@ static int set_bus (struct slot * slot_c }/* This is for x440, once Brandon fixes the firmware, will not need this delay */ -long_delay (1 *HZ ); +msleep (1000 );debug ("%s -Exit\n" , __FUNCTION__);return 0 ; }
_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors
PATCH 1/1 hotplug/ibmphp_hpc: replace long_delay()
In reply to Nishanth AravamudanI would appreciate any comments from the janitors list. This is one (of many) cases where I made a decision about replacing
set_current_state(TASK_INTERRUPTIBLE);schedule_timeout(some_time);
with
msleep(jiffies_to_msecs(some_time));
msleep() is not exactly the same as the previous code, but I only did this replacement where I thought long delays were *desired*. If this is not the case here, then just disregard this patch.
Thanks,
Nish
Applys-to: 2.6.7
Description: Replace long_delay() with msleep() to guarantee the task delays as desired.
drivers/pci/hotplug/ibmphp_hpc.c +9 -10
@@ -205,7 +205,7 @@ static u8 i2c_ctrl_read (struct controll// READ - step 4 : wait until start operation bit clears i =CMD_COMPLETE_TOUT_SEC ;while (i) { -long_delay (1 *HZ /100 ); +msleep (10 ); wpg_addr = WPGBbar +WPG_I2CMCNTL_OFFSET ; wpg_data =readl (wpg_addr); data =swab32 (wpg_data);
@@ -221,7 +221,7 @@ static u8 i2c_ctrl_read (struct controll// READ - step 5 : read I2C status register i =CMD_COMPLETE_TOUT_SEC ;while (i) { -long_delay (1 *HZ /100 ); +msleep (10 ); wpg_addr = WPGBbar +WPG_I2CSTAT_OFFSET ; wpg_data =readl (wpg_addr); data =swab32 (wpg_data);
@@ -316,7 +316,7 @@ static u8 i2c_ctrl_write (struct control// WRITE - step 4 : wait until start operation bit clears i =CMD_COMPLETE_TOUT_SEC ;while (i) { -long_delay (1 *HZ /100 ); +msleep (10 ); wpg_addr = WPGBbar +WPG_I2CMCNTL_OFFSET ; wpg_data =readl (wpg_addr); data =swab32 (wpg_data);
@@ -333,7 +333,7 @@ static u8 i2c_ctrl_write (struct control// WRITE - step 5 : read I2C status register i =CMD_COMPLETE_TOUT_SEC ;while (i) { -long_delay (1 *HZ /100 ); +msleep (10 ); wpg_addr = WPGBbar +WPG_I2CSTAT_OFFSET ; wpg_data =readl (wpg_addr); data =swab32 (wpg_data);
@@ -748,7 +748,7 @@ int ibmphp_hpc_writeslot (struct slot * done = TRUE; }if (!done) { -long_delay (1 *HZ ); +msleep (1000 );if (timeout <1 ) { done = TRUE;err ("%s - Error command complete timeout\n" , __FUNCTION__);
@@ -891,7 +891,7 @@ static void poll_hpc (void)case POLL_SLEEP :/* don't sleep with a lock on the hardware */ up (&semOperations); -long_delay (POLL_INTERVAL_SEC *HZ ); +msleep (POLL_INTERVAL_SEC *1000 );if (ibmphp_shutdown)break ;
@@ -908,8 +908,7 @@ static void poll_hpc (void)/* give up the harware semaphore */ up (&semOperations);/* sleep for a short time just for good measure */ -set_current_state (TASK_INTERRUPTIBLE ); -schedule_timeout (HZ /10 ); +msleep (100 ); }up (&sem_exit);debug ("%s - Exit\n" , __FUNCTION__);
@@ -974,7 +973,7 @@ static int process_changeinstatus (strucif (SLOT_PWRGD (pslot->status)) {// power goes on and off after closing latch // check again to make sure power is still ON -long_delay (1 *HZ ); +msleep (1000 ); rc =ibmphp_hpc_readslot (pslot,READ_SLOTSTATUS , &status);if (SLOT_PWRGD (status)) update = TRUE;
@@ -1147,7 +1146,7 @@ static int hpc_wait_ctlr_notworking (intif (CTLR_WORKING (*pstatus) ==HPC_CTLR_WORKING_NO ) done = TRUE;if (!done) { -long_delay (1 *HZ ); +msleep (1000 );if (timeout <1 ) { done = TRUE;err ("HPCreadslot - Error ctlr timeout\n" );
_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors