Skip to contentSkip to conversation

use list_for_each() i386/pci/pcbios.c

patch-kj Applied maximilian attems 2 participants 2 messages Jul 23, 2004 – Aug 2, 2004

lore
Share & tools
lore

maximilian attems

author
#0 lore raw

Use list_for_each() where applicable
- for (list = ymf_devs.next; list != &ymf_devs; list = list->next) {
+ list_for_each(list, &ymf_devs) {
pure cosmetic change, defined as a preprocessor macro in:
include/linux/list.h

patch against 2.6.7-bk20, please tell if you need against newer.

From: Domen Puncer <[email protected]>

Signed-off-by Maximilian Attems <[email protected]>

---

 linux-2.6.7-bk20-max/arch/i386/pci/pcbios.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)
arch/i386/pci/pcbios.c renamed from arch/i386/pci/pcbios.c~list_for_each-i386pci-pcbios +1 -1
diff -puN arch/i386/pci/pcbios.c~list_for_each-i386pci-pcbios arch/i386/pci/pcbios.c
@@ -365,7 +365,7 @@ void __devinit pcibios_sort(void)
 		idx = found = 0;
 		while (pci_bios_find_device(dev->vendor, dev->device, idx, &bus, &devfn) == PCIBIOS_SUCCESSFUL) {
 			idx++;
-			for (ln=pci_devices.next; ln != &pci_devices; ln=ln->next) {
+			list_for_each(ln, &pci_devices) {
 				d = pci_dev_g(ln);
 				if (d->bus->number == bus && d->devfn == devfn) {
 					list_del(&d->global_list);
Applied
#1 lore raw
Quoted 11 lines · maximilian attems

Use list_for_each() where applicable
- for (list = ymf_devs.next; list != &ymf_devs; list = list->next) {
+ list_for_each(list, &ymf_devs) {
pure cosmetic change, defined as a preprocessor macro in:
include/linux/list.h

patch against 2.6.7-bk20, please tell if you need against newer.

From: Domen Puncer <[email protected]>

Signed-off-by Maximilian Attems <[email protected]>

Applied, thanks.

greg k-h