Skip to contentSkip to conversation

boolean typo in DVB

PATCH Dave Jones 2 participants 2 messages Aug 3, 2004 Media (V4L/DVB)

lore
Share & tools
lore

Dave Jones

author
#0 lore raw

This looks like what was intended here..

Dave

drivers/media/dvb/dvb-core/dvb_demux.c renamed from drivers/media/dvb/dvb-core/dvb_demux.c~ +1 -1
@@ -179,7 +179,7 @@
 		neq |= f->maskandnotmode[i] & xor;
 	}
 
-	if (f->doneq & !neq)
+	if (f->doneq && !neq)
 		return 0;
 
 	return feed->cb.sec (feed->feed.sec.secbuf, feed->feed.sec.seclen, 
#1 lore raw

(The email addresses in the source files are out of date, bug reports should go to linux-dvb-maintainer [at] linuxtv.org.)

Quoted 1 line · Dave Jones

This looks like what was intended here..

...

drivers/media/dvb/dvb-core/dvb_demux.c line 185

Quoted 13 lines
drivers/media/dvb/dvb-core/dvb_demux.c renamed from drivers/media/dvb/dvb-core/dvb_demux.c~ +1 -1
@@ -179,7 +179,7 @@
 		neq |= f->maskandnotmode[i] & xor;
 	}
 
-	if (f->doneq & !neq)
+	if (f->doneq && !neq)
 		return 0;
 
 	return feed->cb.sec (feed->feed.sec.secbuf, feed->feed.sec.seclen, 

Yes, you've spotted a bug. I'll correct this in linuxtv CVS.

Thanks a lot,
Johannes