Skip to contentSkip to conversation

Really call rhine_power_init()

via-rhine Roger Luethi 1 participant 1 message Aug 4, 2004 Network drivers

lore
Share & tools
lore
#0 lore raw

This is a fix for the heisenbug with via-rhine refusing to work sometimes. Patch "[9/9] Restructure reset code" contained a change made necessary by patch [8/9]. Mainline merged [8/9] for 2.6.8 and is still missing the fix, while -mm got it with [9/9].

Jesper Juhl provided crucial test data when no one else was able to reproduce the symptoms.

Roger

drivers/net/via-rhine.c renamed from drivers/net/via-rhine.c.00_broken +2 -2
@@ -748,6 +748,8 @@ static int __devinit rhine_init_one(stru
 	}
 #endif /* USE_MMIO */
 	dev->base_addr = ioaddr;
+	rp = netdev_priv(dev);
+	rp->quirks = quirks;
 
 	rhine_power_init(dev);
 
@@ -792,10 +794,8 @@ static int __devinit rhine_init_one(stru
 
 	dev->irq = pdev->irq;
 
-	rp = netdev_priv(dev);
 	spin_lock_init(&rp->lock);
 	rp->pdev = pdev;
-	rp->quirks = quirks;
 	rp->mii_if.dev = dev;
 	rp->mii_if.mdio_read = mdio_read;
 	rp->mii_if.mdio_write = mdio_write;