Skip to contentSkip to conversation

md raid autodetection on mac partitions

PATCH In review Harald Welte 3 participants 4 messages Aug 6, 2004 – Aug 28, 2004

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 md raid autodetection on mac partitions

Hi!

It took me some time to discover that there is no provision in the mac parition handling code for autodetection of md raid arrays.

Is there any particular reason why this isn't implemented?

I've now added a new partition type 'Linux_raid_autodetect', which can be used for md autodetect.

Please consider inclusion of this patch.

--
- Harald Welte <[email protected]> http://www.gnumonks.org/
============================================================================
Programming is like sex: One mistake and you have to support it your lifetime

fs/partitions/mac.c +7 -0
@@ -4,6 +4,10 @@
  *  Code extracted from drivers/block/genhd.c
  *  Copyright (C) 1991-1998  Linus Torvalds
  *  Re-organised Feb 1998 Russell King
+ *
+ *  2004-08-05 Harald Welte <[email protected]>:
+ *  	- Add support for md-raid autodetection to make md-raid bootable
+ *	  (Partition type "Linux_raid_autodetect")
  */
 
 #include <linux/config.h>
@@ -110,6 +114,9 @@
 					goodness--;
 			}
 
+			if (strcasecmp(part->type, "Linux_raid_autodetect") == 0)
+				state->parts[slot].flags = 1;
+
 			if (goodness > found_root_goodness) {
 				found_root = blk;
 				found_root_goodness = goodness;
#1 lore raw
Quoted 11 lines · Harald Welte

Hi!

It took me some time to discover that there is no provision in the mac parition handling code for autodetection of md raid arrays.

Is there any particular reason why this isn't implemented?

I've now added a new partition type 'Linux_raid_autodetect', which can be used for md autodetect.

Please consider inclusion of this patch.

No. raid autodetection is deprectaed, we don't want it for more
partiton types.

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

#2 lore raw
Quoted 2 lines · Christoph Hellwig

No. raid autodetection is deprectaed, we don't want it for more
partiton types.

Oh well. I guess I'm the only user who likes to boot his machine without building some initrd - especially since this never works out of the box with any vendor-supplied tools on any distribution I've tried so far.

If autodetection is deprecated, will we at least see some kernel boot option, where one could specify which partitions to use?

--
- Harald Welte <[email protected]> http://www.gnumonks.org/
============================================================================
Programming is like sex: One mistake and you have to support it your lifetime

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

#3 lore raw
In reply to Harald Welte
Quoted 9 lines · Harald Welte

Hi!

It took me some time to discover that there is no provision in the mac parition handling code for autodetection of md raid arrays.

Is there any particular reason why this isn't implemented?

I've now added a new partition type 'Linux_raid_autodetect', which can be used for md autodetect.

Hi Harald, just found this patch, sorry for the delay.

Why just not "Linux_raid" ?

Ben.

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/