Skip to contentSkip to conversation

kbuild: Remove LANG preset in top-level Makefile

PATCH New Sam Ravnborg 1 participant 1 message Aug 7, 2004 Kbuild

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kbuild: Remove LANG preset in top-level Makefile

Hi Linus, please apply before 2.6.8 final!

In the top-level Makefile a number of locale related environment variables were preset to give a small speed up when building the kernel.
Unfortunately this had the bad sideeffect that the variable CFLAGS_vmlinux.lds.o lost the exported vaule in some setups (obviously not mine).
This smells like a make issue - but the best solution is simply to drop presetting the locale related variables.

===== Makefile 1.509 vs edited =====

Makefile +1 -6
@@ -619,12 +619,7 @@
 
 .PHONY: $(vmlinux-dirs)
 $(vmlinux-dirs): prepare-all scripts
-	$(Q)if [ ! -z $$LC_ALL ]; then          \
-		export LANG=$$LC_ALL;           \
-		export LC_ALL= ;                \
-	fi;                                     \
-	export LC_COLLATE=C; export LC_CTYPE=C; \
-	$(MAKE) $(build)=$@
+	$(Q)$(MAKE) $(build)=$@
 
 # Things we need to do before we recursively start building the kernel
 # or the modules are listed in "prepare-all".