2.6.8.1-kjt1
Subsystems (4)
Quoted 1 line · maximilian attems
msleep-drivers_net_slip.patch
CC [M] drivers/net/slip.o
drivers/net/slip.c: In function `slip_exit':
drivers/net/slip.c:1394: warning: implicit declaration of function `msleep'
Added include, to fix this:
Original from Nishanth Aravamudan <[email protected]>
drivers/net/slip.c +3 -4
@@ -74,6 +74,7 @@#include <linux/if_arp.h> #include <linux/if_slip.h> #include <linux/init.h> +#include <linux/delay.h> #include "slip.h" #ifdef CONFIG_INET #include <linux/ip.h>
@@ -1390,10 +1391,8 @@ static void __exit slip_exit(void)/* First of all: check for active disciplines and hangup them. */ do { - if (busy) { - set_current_state(TASK_INTERRUPTIBLE); - schedule_timeout(HZ / 10); - } + if (busy) + msleep(100); busy = 0; for (i = 0; i < slip_maxdev; i++) {
_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors
Quoted 9 lines · Domen Puncer
Quoted 1 line · maximilian attems
msleep-drivers_net_slip.patch
CC [M]
drivers/net/slip.o
drivers/net/slip.c: In function `slip_exit':
drivers/net/slip.c:1394: warning: implicit declaration of function `msleep'Added include, to fix this:
great thanks for the testing and quick fis,
ill add that patch before sending to akpm.
a++ maks
_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors
Compile-warning fixes for 2 patches follow...
Quoted 1 line · maximilian attems
msleep-drivers_scsi_eta_pio.patch
CC drivers/scsi/eata_pio.o
drivers/scsi/eata_pio.c: In function `eata_pio_host_reset':
drivers/scsi/eata_pio.c:514: warning: implicit declaration of function `msleep'
Original from: Nishanth Aravamudan <[email protected]>
drivers/scsi/eata_pio.c +2 -2
@@ -59,6 +59,7 @@#include <linux/interrupt.h> #include <linux/blkdev.h> #include <linux/spinlock.h> +#include <linux/delay.h> #include <asm/io.h> #include <scsi/scsi.h>
@@ -511,8 +512,7 @@ static int eata_pio_host_reset(struct scHD (cmd)->state =RESET ;spin_unlock_irq (host->host_lock); -set_current_state (TASK_UNINTERRUPTIBLE ); -schedule_timeout (3 *HZ ); +msleep (3000 );spin_lock_irq (host->host_lock);DBG (DBG_ABNORM ,printk (KERN_WARNING "eata_pio_reset: interrupts disabled, " "loops %d.\n" , limit));
Quoted 1 line
msleep-drivers_scsi_qla2xxx_qla_os.patch
CC drivers/scsi/qla2xxx/qla_os.o
drivers/scsi/qla2xxx/qla_os.c: In function `qla2x00_wait_for_hba_online':
drivers/scsi/qla2xxx/qla_os.c:972: warning: implicit declaration of function `msleep'
Original from: Nishanth Aravamudan <[email protected]>
drivers/scsi/qla2xxx/qla_os.c +13 -24
@@ -21,6 +21,7 @@#include <linux/moduleparam.h> #include <linux/vmalloc.h> #include <linux/smp_lock.h> +#include <linux/delay.h> #include <scsi/scsi_tcq.h> #include <scsi/scsicam.h>
@@ -969,8 +970,7 @@ qla2x00_wait_for_hba_online(scsi_qla_hos test_bit(ISP_ABORT_RETRY, &ha->dpc_flags) || ha->dpc_active) && time_before(jiffies, wait_online)) { -set_current_state (TASK_UNINTERRUPTIBLE ); -schedule_timeout (HZ ); +msleep (1000 ); }if (ha->flags.online) return_status =QLA_SUCCESS ;
@@ -1011,8 +1011,7 @@ qla2x00_wait_for_loop_ready(scsi_qla_hos atomic_read(&ha->loop_state) == LOOP_DOWN) || test_bit(CFG_ACTIVE, &ha->cfg_flags) || atomic_read(&ha->loop_state) != LOOP_READY) { -set_current_state (TASK_UNINTERRUPTIBLE ); -schedule_timeout (HZ ); +msleep (1000 );if (time_after_eq (jiffies, loop_timeout)) { return_status =QLA_FUNCTION_FAILED ;break ;
@@ -2120,8 +2119,7 @@ int qla2x00_probe_one(struct pci_dev *pdqla2x00_check_fabric_devices (ha); -set_current_state (TASK_UNINTERRUPTIBLE ); -schedule_timeout (HZ /100 ); +msleep (10 ); }pci_set_drvdata (pdev, ha);
@@ -2833,8 +2831,7 @@ qla2x00_mem_alloc(scsi_qla_host_t *ha) "Memory Allocation failed - request_ring\n");qla2x00_mem_free (ha); -set_current_state (TASK_UNINTERRUPTIBLE ); -schedule_timeout (HZ /10 ); +msleep (100 );continue ; }
@@ -2847,8 +2844,7 @@ qla2x00_mem_alloc(scsi_qla_host_t *ha) "Memory Allocation failed - response_ring\n");qla2x00_mem_free (ha); -set_current_state (TASK_UNINTERRUPTIBLE ); -schedule_timeout (HZ /10 ); +msleep (100 );continue ; }
@@ -2861,8 +2857,7 @@ qla2x00_mem_alloc(scsi_qla_host_t *ha) "Memory Allocation failed - init_cb\n");qla2x00_mem_free (ha); -set_current_state (TASK_UNINTERRUPTIBLE ); -schedule_timeout (HZ /10 ); +msleep (100 );continue ; }
@@ -2874,8 +2869,7 @@ qla2x00_mem_alloc(scsi_qla_host_t *ha) "Memory Allocation failed - ioctl_mem\n");qla2x00_mem_free (ha); -set_current_state (TASK_UNINTERRUPTIBLE ); -schedule_timeout (HZ /10 ); +msleep (100 );continue ; }
@@ -2886,8 +2880,7 @@ qla2x00_mem_alloc(scsi_qla_host_t *ha) "qla2x00_allocate_sp_pool()\n");qla2x00_mem_free (ha); -set_current_state (TASK_UNINTERRUPTIBLE ); -schedule_timeout (HZ /10 ); +msleep (100 );continue ; }
@@ -2903,8 +2896,7 @@ qla2x00_mem_alloc(scsi_qla_host_t *ha) "Memory Allocation failed - sns_cmd\n");qla2x00_mem_free (ha); -set_current_state (TASK_UNINTERRUPTIBLE ); -schedule_timeout (HZ /10 ); +msleep (100 );continue ; }
@@ -2919,8 +2911,7 @@ qla2x00_mem_alloc(scsi_qla_host_t *ha) "Memory Allocation failed - ms_iocb\n");qla2x00_mem_free (ha); -set_current_state (TASK_UNINTERRUPTIBLE ); -schedule_timeout (HZ /10 ); +msleep (100 );continue ; }
@@ -2938,8 +2929,7 @@ qla2x00_mem_alloc(scsi_qla_host_t *ha) "Memory Allocation failed - ct_sns\n");qla2x00_mem_free (ha); -set_current_state (TASK_UNINTERRUPTIBLE ); -schedule_timeout (HZ /10 ); +msleep (100 );continue ; }
@@ -2955,8 +2945,7 @@ qla2x00_mem_alloc(scsi_qla_host_t *ha) "Memory Allocation failed - iodesc_pd\n");qla2x00_mem_free (ha); -set_current_state (TASK_UNINTERRUPTIBLE ); -schedule_timeout (HZ /10 ); +msleep (100 );continue ; }
_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors
Quoted 2 lines · Domen Puncer
Compile-warning fixes for 2 patches follow...
great for your testing domen, thanks.
forwarded to akpm.
hope other kernel janitors are also running kjt?
a++ maks
_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors