remove read-only/immutable checks from fat_truncate
Subsystems (2)
PATCH 1/1 remove read-only/immutable checks from fat_truncate
Looking through Herberts bind-mount patches I saw that fat_truncate checks for the inode beeing read-only or immutable.
This looks wrong to me. Rationale:
There's two callers:
- the truncate path via notify_change, ->setattr, vmtruncate. We already check for permissions here at the upper level
- fat_delete_inode. This one looks bogus to me - even if we delete an read-only or immutable inode we want to free the space allocated by it, else you leak disk blocks.
fs/fat/file.c +0 -6
@@ -90,12 +90,6 @@const unsigned int cluster_size = sbi->cluster_size;int nr_clusters; -/* Why no return value? Surely the disk could fail... */ -if (IS_RDONLY (inode)) -return /* -EPERM */ ; -if (IS_IMMUTABLE (inode)) -return /* -EPERM */ ; -/* * This protects against truncating a file bigger than it was then * trying to write into the hole.
OGAWA Hirofumi
maintainerQuoted 4 lines · Christoph Hellwig
Looking through Herberts bind-mount patches I saw that
fat_truncatechecks for the inode beeing read-only or immutable.This looks wrong to me. Rationale:
Yes.
Looks good to me. Since vfs layer is already checking those flags at all path, I think those are unneeded.
(open, truncate, unlink, and rmdir)
Please appply the Christoph's patch.
Thanks.
Signature · 30 lines
OGAWA Hirofumi <[email protected]> Signed-off-by: OGAWA Hirofumi <[email protected]> There's two callers: - the truncate path via notify_change, ->setattr, vmtruncate. We already check for permissions here at the upper level - fat_delete_inode. This one looks bogus to me - even if we delete an read-only or immutable inode we want to free the space allocated by it, else you leak disk blocks. --- 1.25/fs/fat/file.c 2004-05-25 11:53:07 +02:00 +++ edited/fs/fat/file.c 2004-08-18 16:32:42 +02:00 @@ -90,12 +90,6 @@ const unsigned int cluster_size = sbi->cluster_size; int nr_clusters; - /* Why no return value? Surely the disk could fail... */ - if (IS_RDONLY (inode)) - return /* -EPERM */; - if (IS_IMMUTABLE(inode)) - return /* -EPERM */; - /* * This protects against truncating a file bigger than it was then * trying to write into the hole.