Skip to contentSkip to conversation

dothan speedstep fix

PATCH In review Con Kolivas 3 participants 5 messages Aug 20, 2004

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dothan speedstep fix

Hi Jeremy

My new dothan cpu comes up as stepping 6. This patch fixes speedstep support for my laptop unless it can come up as multiple stepping values? Now all I need is for a way to make it report the correct L2 cache.

arch/i386/kernel/cpu/cpufreq/speedstep-centrino.c +1 -1
Index: linux-2.6.8.1-ck/arch/i386/kernel/cpu/cpufreq/speedstep-centrino.c
===================================================================
@@ -57,7 +57,7 @@ static const struct cpu_id cpu_id_dothan
 	.x86_vendor = X86_VENDOR_INTEL,
 	.x86 = 6,
 	.x86_model = 13,
-	.x86_mask = 1,
+	.x86_mask = 6,
 };
 
 struct cpu_model
#1 lore raw
Quoted 1 line · Con Kolivas

Now all I need is for a way to make it report the correct L2 cache.

How's this look ?

Dave

Update Intel cache descriptor decoding to match latest Intel Documentation (24161827.pdf)

arch/i386/kernel/cpu/intel.c renamed from arch/i386/kernel/cpu/intel.c~ +3 -0
@@ -96,10 +96,13 @@
 	{ 0x70, LVL_TRACE,  12 },
 	{ 0x71, LVL_TRACE,  16 },
 	{ 0x72, LVL_TRACE,  32 },
+	{ 0x78, LVL_2,		1024 },
 	{ 0x79, LVL_2,      128 },
 	{ 0x7a, LVL_2,      256 },
 	{ 0x7b, LVL_2,      512 },
 	{ 0x7c, LVL_2,      1024 },
+	{ 0x7d, LVL_2,		2048 },
+	{ 0x7f, LVL_2,		512 },
 	{ 0x82, LVL_2,      256 },
 	{ 0x83, LVL_2,      512 },
 	{ 0x84, LVL_2,      1024 },
#2 lore raw
In reply to Con Kolivas
Quoted 5 lines · Con Kolivas

Hi Jeremy

My new dothan cpu comes up as stepping 6. This patch fixes speedstep support for my laptop unless it can come up as multiple stepping values? Now all I need is for a way to make it report the correct L2 cache.

The patch I posted to l/k a few minutea ago should fix the L2 cache reporting.

#3 lore raw
Quoted 9 lines · Alan Cox
Quoted 3 lines · Con Kolivas

Hi Jeremy

My new dothan cpu comes up as stepping 6. This patch fixes speedstep support for my laptop unless it can come up as multiple stepping values? Now all I need is for a way to make it report the correct L2 cache.

The patch I posted to l/k a few minutea ago should fix the L2 cache reporting.

Looks like you preempted DaveJ by a handful of emails.

Both patches look good (especially since they're identical ;))

processor : 0
vendor_id : GenuineIntel
cpu family : 6
model : 13
model name : Intel(R) Pentium(R) M processor 1.70GHz
stepping : 6
cpu MHz : 1700.414
cache size : 2048 KB
fdiv_bug : no
hlt_bug : no
f00f_bug : no
coma_bug : no
fpu : yes
fpu_exception : yes
cpuid level : 2
wp : yes
flags : fpu vme de pse tsc msr mce cx8 apic sep mtrr pge mca cmov pat clflush dts acpi mmx fxsr sse sse2 ss tm pbe tm2 est
bogomips : 3366.91

Thanks!

Cheers,
Con

#4 lore raw
Quoted 10 lines · Con Kolivas
Quoted 9 lines · Alan Cox
Quoted 5 lines · Con Kolivas

Hi Jeremy

My new dothan cpu comes up as stepping 6. This patch fixes speedstep support for my laptop unless it can come up as multiple stepping values? Now all I need is for a way to make it report the correct L2 cache.

Quoted 6 lines
Quoted 2 lines

The patch I posted to l/k a few minutea ago should fix the L2 cache reporting.

Looks like you preempted DaveJ by a handful of emails.

Both patches look good (especially since they're identical ;))

Not quite 8-) Alan's missed off 0x7f

Dave