Skip to contentSkip to conversation

Replacement for pci_for_each_dev()?

Kernel-janitors max attems 2 participants 3 messages Aug 23, 2004 Kernel janitors

lore
Share & tools
lore

max attems

author
#0 lore raw

hello greg,

Quoted 11 lines · Greg KH
Quoted 8 lines · Timur Tabi
Quoted 3 lines · Greg KH
Quoted 1 line

pci_for_each_dev() Superseded by pci_find_device()

No! Use pci_get_device(), pci_find_device() is about to be deleted.

Looking at pci.txt, it appears that if I use pci_get_device(), I will also need to use pci_dev_put().

That is correct.

~/src/linux-2.6.8$ egrep -r 'pci_find_device' drivers/ | wc -l 195

i saw this in your weblog,
could we add this item to the kernel janitor todo list? have you any further info or pointer to help any takers? like a patch you already submitted?

adding kj on cc, thanks

--
maks
kernel janitor http://janitor.kernelnewbies.org/

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors

#1 lore raw
Quoted 6 lines · max attems

~/src/linux-2.6.8$ egrep -r 'pci_find_device' drivers/ | wc -l 195

i saw this in your weblog,
could we add this item to the kernel janitor todo list?

Sure.

Quoted 2 lines

have you any further info or pointer to help any takers? like a patch you already submitted?

I did a bunch of cleanups like it a long time ago (during 2.5), but I don't have a pointer at this moment, sorry.

tanks,

greg k-h

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors

author
#2 lore raw
In reply to max attems
Quoted 8 lines · Greg KH
Quoted 6 lines · max attems

~/src/linux-2.6.8$ egrep -r 'pci_find_device' drivers/ | wc -l 195

i saw this in your weblog,
could we add this item to the kernel janitor todo list?

Quoted 7 lines

Sure.

Quoted 2 lines

have you any further info or pointer to help any takers? like a patch you already submitted?

I did a bunch of cleanups like it a long time ago (during 2.5), but I don't have a pointer at this moment, sorry.

added to the kj TODO -> http://janitor.kernelnewbies.org/TODO
will add pointer as soon one shows up. :)
thanks

--
maks
kernel janitor http://janitor.kernelnewbies.org/

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors