Skip to contentSkip to conversation

mark install_page static

PATCH In review Christoph Hellwig 5 participants 9 messages Sep 7, 2004 – Sep 9, 2004 Memory management

lore
Share & tools
lore

Christoph Hellwig

author
#0 lore raw

PATCH 1/1 mark install_page static

Not used anywhere in modules and it really shouldn't either.

mm/fremap.c +0 -2
@@ -99,8 +99,6 @@
 	spin_unlock(&mm->page_table_lock);
 	return err;
 }
-EXPORT_SYMBOL(install_page);
-
 
 /*
  * Install a file pte to a given virtual memory address, release any
#1 lore raw
Quoted 1 line · Christoph Hellwig

Not used anywhere in modules and it really shouldn't either.

Doesn't that happen (conveniently from some viewpoints Im sure) to break vmware ?

author
#2 lore raw
Quoted 5 lines · Alan Cox
Quoted 1 line · Christoph Hellwig

Not used anywhere in modules and it really shouldn't either.

Doesn't that happen (conveniently from some viewpoints Im sure) to break vmware ?

It happens because Arjan & I wrote up some scripts to find dead exports.

#3 lore raw
Quoted 8 lines · Christoph Hellwig
Quoted 5 lines · Alan Cox
Quoted 1 line · Christoph Hellwig

Not used anywhere in modules and it really shouldn't either.

Doesn't that happen (conveniently from some viewpoints Im sure) to break vmware ?

It happens because Arjan & I wrote up some scripts to find dead exports.

Sure. Most of them look good but some of them look a little dubious. Now as I was asking - doesn't this break vmware ?

author
#4 lore raw
Quoted 4 lines · Alan Cox
Quoted 1 line

It happens because Arjan & I wrote up some scripts to find dead exports.

Sure. Most of them look good but some of them look a little dubious. Now as I was asking - doesn't this break vmware ?

And the answer is: I don't know because the vmware module license isn't free software and thus I haven't taken a look. Given Petr's answer probably yes - but because it's above mentioned license I don't particularly care.

#5 lore raw
In reply to Christoph Hellwig

On Tue, 7 Sep 2004 20:12:59 +0200 Christoph Hellwig wrote:

| On Tue, Sep 07, 2004 at 06:09:29PM +0100, Alan Cox wrote:
| > On Maw, 2004-09-07 at 15:37, Christoph Hellwig wrote:
| > > Not used anywhere in modules and it really shouldn't either.
| > 
| > Doesn't that happen (conveniently from some viewpoints Im sure) to break
| > vmware ?
| 
| It happens because Arjan & I wrote up some scripts to find dead exports.

Can you put those at kernelnewbies.org or janitor.kernelnewbies.org ?

--
~Randy

#6 lore raw
Quoted 11 lines · Randy.Dunlap

On Tue, 7 Sep 2004 20:12:59 +0200 Christoph Hellwig wrote:

| On Tue, Sep 07, 2004 at 06:09:29PM +0100, Alan Cox wrote:
| > On Maw, 2004-09-07 at 15:37, Christoph Hellwig wrote:
| > > Not used anywhere in modules and it really shouldn't either.
| > 
| > Doesn't that happen (conveniently from some viewpoints Im sure) to break
| > vmware ?
| 
| It happens because Arjan & I wrote up some scripts to find dead exports.
Quoted 1 line

Can you put those at kernelnewbies.org or janitor.kernelnewbies.org ?

Keith Ownes 'namespacecheck' flags unused exported symbols as well. And furthermore unused non-static definitions.

Present in -mm only atm.

Usage: make && make namespacecheck

Dependent on actual configuration so output should be read carefully. Should be good on a make allmodconfig or make allyesconfig

Sam

author
#7 lore raw
Quoted 12 lines · Sam Ravnborg
Quoted 11 lines · Randy.Dunlap

On Tue, 7 Sep 2004 20:12:59 +0200 Christoph Hellwig wrote:

| On Tue, Sep 07, 2004 at 06:09:29PM +0100, Alan Cox wrote:
| > On Maw, 2004-09-07 at 15:37, Christoph Hellwig wrote:
| > > Not used anywhere in modules and it really shouldn't either.
| > 
| > Doesn't that happen (conveniently from some viewpoints Im sure) to break
| > vmware ?
| 
| It happens because Arjan & I wrote up some scripts to find dead exports.
Quoted 4 lines
Quoted 1 line

Can you put those at kernelnewbies.org or janitor.kernelnewbies.org ?

Keith Ownes 'namespacecheck' flags unused exported symbols as well. And furthermore unused non-static definitions.

Well, to get halfway reliable data you need to merge the data from multiple architectures. And then do lots of manual grepping for every instance to be sure.

#8 lore raw
In reply to Christoph Hellwig
Quoted 8 lines · Christoph Hellwig
Quoted 5 lines · Alan Cox
Quoted 1 line · Christoph Hellwig

Not used anywhere in modules and it really shouldn't either.

Doesn't that happen (conveniently from some viewpoints Im sure) to break vmware ?

It happens because Arjan & I wrote up some scripts to find dead exports.

are those available somewhere?

sorry google didn't have a good answer for me ...

TIA,
Herbert

Quoted 5 lines

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/