Skip to contentSkip to conversation

unexport do_execve/do_select

PATCH In review Christoph Hellwig 3 participants 4 messages Sep 7, 2004

Subsystems (2)
VFS exec and binfmt
lore
Share & tools
lore

Christoph Hellwig

author
#0 lore raw

PATCH 1/1 unexport do_execve/do_select

These are basically shared code for native/32bit compat code, but as CONFIG_COMPAT is a bool there's no need to export them.

fs/exec.c +0 -2
@@ -1187,8 +1187,6 @@
 	return retval;
 }
 
-EXPORT_SYMBOL(do_execve);
-
 int set_binfmt(struct linux_binfmt *new)
 {
 	struct linux_binfmt *old = current->binfmt;
fs/select.c +0 -2
@@ -267,8 +267,6 @@
 	return retval;
 }
 
-EXPORT_SYMBOL(do_select);
-
 static void *select_bits_alloc(int size)
 {
 	return kmalloc(6 * size, GFP_KERNEL);
#1 lore raw
Quoted 2 lines · Christoph Hellwig

These are basically shared code for native/32bit compat code, but as CONFIG_COMPAT is a bool there's no need to export them.

do_select at least used to be used by the xABI compatibility modules, is that no longer the case ?

author
#2 lore raw
Quoted 6 lines · Alan Cox
Quoted 2 lines · Christoph Hellwig

These are basically shared code for native/32bit compat code, but as CONFIG_COMPAT is a bool there's no need to export them.

do_select at least used to be used by the xABI compatibility modules, is that no longer the case ?

For Sparc, the only inkernel one that can be modular - no. For the x86 ABI modules half of the syscalls needs to be exported so the patch is huge anyway.

#3 lore raw
In reply to Alan Cox
Quoted 6 lines · Alan Cox
Quoted 2 lines · Christoph Hellwig

These are basically shared code for native/32bit compat code, but as CONFIG_COMPAT is a bool there's no need to export them.

do_select at least used to be used by the xABI compatibility modules, is that no longer the case ?

I thought those no longer existed; lots of other stuff is missing for those as well for sure.