remove wake_up_all_sync
PATCH 1/1 remove wake_up_all_sync
no user in sight
include/linux/wait.h +0 -1
@@ -129,7 +129,6 @@#define wake_up (x) __wake_up(x, TASK_UNINTERRUPTIBLE | TASK_INTERRUPTIBLE, 1, NULL)#define wake_up_nr (x, nr) __wake_up(x, TASK_UNINTERRUPTIBLE | TASK_INTERRUPTIBLE, nr, NULL)#define wake_up_all (x) __wake_up(x, TASK_UNINTERRUPTIBLE | TASK_INTERRUPTIBLE, 0, NULL) -#define wake_up_all_sync (x) __wake_up_sync((x),TASK_UNINTERRUPTIBLE | TASK_INTERRUPTIBLE, 0)#define wake_up_interruptible (x) __wake_up(x, TASK_INTERRUPTIBLE, 1, NULL)#define wake_up_interruptible_nr (x, nr) __wake_up(x, TASK_INTERRUPTIBLE, nr, NULL)#define wake_up_interruptible_all (x) __wake_up(x, TASK_INTERRUPTIBLE, 0, NULL)
Quoted 1 line · Christoph Hellwig
no user in sight
That doesn't mean its not a logical part of the API, and since its a define one which has zero cost in being present. I think you are taking things beyond the ridiculous in this area.
Alan
Quoted 6 lines · Alan Cox
Quoted 1 line · Christoph Hellwig
no user in sight
That doesn't mean its not a logical part of the API, and since its a define one which has zero cost in being present. I think you are taking things beyond the ridiculous in this area.
The sync wakeups are an absolutely special case, we're only using them in the pipe code on __wake_up_parent. If you think it's a logical part of the API were would you want to use it for?
Quoted 3 lines · Christoph Hellwig
The sync wakeups are an absolutely special case, we're only using them in the pipe code on
__wake_up_parent. If you think it's a logical part of the API were would you want to use it for?
Fair comment on grepping and more digging - objection dropped