Skip to contentSkip to conversation

ppc32: Fix arch/ppc/boot/common/ns16550.c

PATCH Superseded Tom Rini 1 participant 2 messages Sep 11, 2004 – Sep 14, 2004

lore
Share & tools
lore

Tom Rini

author
#0 lore raw

PATCH 1/1 ppc32: Fix arch/ppc/boot/common/ns16550.c

Hello. When <linux/timex.h> started including <asm/io.h> this exposed one of the fragilities of the code in arch/ppc/boot/, namely that it is tied to the kernel headers for some information, yet not really the kernel. The following starts us in the direction of being less tied to the kernel by providing our own serial_state definition (all we care about is the ability to grab information from SERIAL_PORT_DFNS).

arch/ppc/boot/common/ns16550.c +3 -3
@@ -5,14 +5,14 @@
 #include <linux/config.h>
 #include <linux/types.h>
 #include <linux/serial.h>
-#include <linux/serialP.h>
 #include <linux/serial_reg.h>
 #include <asm/serial.h>
 
+#include "nonstdio.h"
+#include "serial.h"
+
 #define SERIAL_BAUD	9600
 
-extern void outb(int port, unsigned char val);
-extern unsigned char inb(int port);
 extern unsigned long ISA_io;
 
 static struct serial_state rs_table[RS_TABLE_SIZE] = {
arch/ppc/boot/include/serial.h new file +46 -0

46 lines not on this page · raw message

Signature · 2 lines
Tom Rini
http://gate.crashing.org/~trini/
author
#1 lore raw

PATCH RESEND 1/1 ppc32: Fix arch/ppc/boot/common/ns16550.c

[ Originally sent Sat, Sept 11 2004 ]

Hello. When <linux/timex.h> started including <asm/io.h> this exposed one of the fragilities of the code in arch/ppc/boot/, namely that it is tied to the kernel headers for some information, yet not really the kernel. The following starts us in the direction of being less tied to the kernel by providing our own serial_state definition (all we care about is the ability to grab information from SERIAL_PORT_DFNS).

arch/ppc/boot/common/ns16550.c +3 -3
@@ -5,14 +5,14 @@
 #include <linux/config.h>
 #include <linux/types.h>
 #include <linux/serial.h>
-#include <linux/serialP.h>
 #include <linux/serial_reg.h>
 #include <asm/serial.h>
 
+#include "nonstdio.h"
+#include "serial.h"
+
 #define SERIAL_BAUD	9600
 
-extern void outb(int port, unsigned char val);
-extern unsigned char inb(int port);
 extern unsigned long ISA_io;
 
 static struct serial_state rs_table[RS_TABLE_SIZE] = {
arch/ppc/boot/include/serial.h new file +46 -0

46 lines not on this page · raw message

Signature · 2 lines
Tom Rini
http://gate.crashing.org/~trini/