Skip to contentSkip to conversation

ide: remove obsolete CONFIG_BLK_DEV_ADMA

PATCH In review Raphael Zimmerer 2 participants 4 messages Sep 14, 2004 – Sep 15, 2004

Subsystems (6)
Arm (32-bit) PowerPC MIPS libata +2 more subsystems
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 ide: remove obsolete CONFIG_BLK_DEV_ADMA

From: Raphael Zimmerer <[email protected]>

In drivers/ide/Kconfig there's a hidden config-item named BLK_DEV_ADMA. Nowhere in the sources are any references to this item, so this option simply is obsolete.

This patch removes the according item from drivers/ide/Kconfig.

---

 drivers/ide/Kconfig |    5 -----
 1 files changed, 5 deletions(-)
drivers/ide/Kconfig +0 -5
@@ -457,11 +457,6 @@ config IDEDMA_ONLYDISK
 
 	  Generally say N here.
 
-config BLK_DEV_ADMA
-	bool
-	depends on PCI && BLK_DEV_IDEPCI
-	default BLK_DEV_IDEDMA_PCI
-
 config BLK_DEV_AEC62XX
 	tristate "AEC62XX chipset support"
 	help
#1 lore raw

PATCH 2/2 ide: remove obsolete CONFIG_BLK_DEV_ADMA - cleanup arch

From: Raphael Zimmerer <[email protected]>

Cleans up default config for various archs, removing CONFIG_BLK_DEV_IDEPCI

---

 arch/alpha/defconfig                 |    1 -
 arch/arm/configs/iq80321_defconfig   |    1 -
 arch/arm/configs/ixp4xx_defconfig    |    1 -
 arch/arm/configs/netwinder_defconfig |    1 -
 arch/i386/defconfig                  |    1 -
 arch/ia64/configs/generic_defconfig  |    1 -
 arch/ia64/configs/sn2_defconfig      |    1 -
 arch/ia64/configs/zx1_defconfig      |    1 -
 arch/ia64/defconfig                  |    1 -
 arch/mips/configs/lasat200_defconfig |    1 -
 arch/mips/configs/pb1500_defconfig   |    1 -
 arch/mips/configs/pb1550_defconfig   |    1 -
 arch/parisc/configs/c3000_defconfig  |    1 -
 arch/ppc/configs/common_defconfig    |    1 -
 arch/ppc/configs/k2_defconfig        |    1 -
 arch/ppc/configs/lopec_defconfig     |    1 -
 arch/ppc/configs/mcpn765_defconfig   |    1 -
 arch/ppc/configs/pmac_defconfig      |    1 -
 arch/ppc/defconfig                   |    1 -
 arch/ppc64/configs/g5_defconfig      |    1 -
 arch/ppc64/configs/pSeries_defconfig |    1 -
 arch/ppc64/defconfig                 |    1 -
 arch/sparc64/defconfig               |    1 -
 arch/x86_64/defconfig                |    1 -
 24 files changed, 24 deletions(-)
arch/alpha/defconfig +0 -1
diff -Nur linux-2.6.8.1/arch/alpha/defconfig linux-2.6.8.1-no-BLK_DEV_ADMA/arch/alpha/defconfig
@@ -181,7 +181,6 @@
 # CONFIG_BLK_DEV_IDEDMA_FORCED is not set
 CONFIG_IDEDMA_PCI_AUTO=y
 # CONFIG_IDEDMA_ONLYDISK is not set
-CONFIG_BLK_DEV_ADMA=y
 # CONFIG_BLK_DEV_AEC62XX is not set
 CONFIG_BLK_DEV_ALI15X3=y
 # CONFIG_WDC_ALI15X3 is not set
arch/arm/configs/iq80321_defconfig +0 -1
diff -Nur linux-2.6.8.1/arch/arm/configs/iq80321_defconfig linux-2.6.8.1-no-BLK_DEV_ADMA/arch/arm/configs/iq80321_defconfig
@@ -439,7 +439,6 @@
 CONFIG_IDEDMA_PCI_AUTO=y
 # CONFIG_IDEDMA_ONLYDISK is not set
 CONFIG_BLK_DEV_IDEDMA=y
-CONFIG_BLK_DEV_ADMA=y
 # CONFIG_BLK_DEV_AEC62XX is not set
 # CONFIG_BLK_DEV_ALI15X3 is not set
 # CONFIG_BLK_DEV_AMD74XX is not set
arch/arm/configs/ixp4xx_defconfig +0 -1
diff -Nur linux-2.6.8.1/arch/arm/configs/ixp4xx_defconfig linux-2.6.8.1-no-BLK_DEV_ADMA/arch/arm/configs/ixp4xx_defconfig
@@ -674,7 +674,6 @@
 CONFIG_BLK_DEV_IDEDMA_PCI=y
 # CONFIG_BLK_DEV_IDEDMA_FORCED is not set
 # CONFIG_IDEDMA_PCI_AUTO is not set
-CONFIG_BLK_DEV_ADMA=y
 # CONFIG_BLK_DEV_AEC62XX is not set
 # CONFIG_BLK_DEV_ALI15X3 is not set
 # CONFIG_BLK_DEV_AMD74XX is not set
arch/arm/configs/netwinder_defconfig +0 -1
diff -Nur linux-2.6.8.1/arch/arm/configs/netwinder_defconfig linux-2.6.8.1-no-BLK_DEV_ADMA/arch/arm/configs/netwinder_defconfig
@@ -437,7 +437,6 @@
 # CONFIG_BLK_DEV_IDEDMA_FORCED is not set
 CONFIG_IDEDMA_PCI_AUTO=y
 # CONFIG_IDEDMA_ONLYDISK is not set
-CONFIG_BLK_DEV_ADMA=y
 # CONFIG_BLK_DEV_AEC62XX is not set
 # CONFIG_BLK_DEV_ALI15X3 is not set
 # CONFIG_BLK_DEV_AMD74XX is not set
arch/i386/defconfig +0 -1
diff -Nur linux-2.6.8.1/arch/i386/defconfig linux-2.6.8.1-no-BLK_DEV_ADMA/arch/i386/defconfig
@@ -288,7 +288,6 @@
 # CONFIG_BLK_DEV_IDEDMA_FORCED is not set
 CONFIG_IDEDMA_PCI_AUTO=y
 # CONFIG_IDEDMA_ONLYDISK is not set
-CONFIG_BLK_DEV_ADMA=y
 # CONFIG_BLK_DEV_AEC62XX is not set
 # CONFIG_BLK_DEV_ALI15X3 is not set
 # CONFIG_BLK_DEV_AMD74XX is not set
arch/ia64/configs/generic_defconfig +0 -1
diff -Nur linux-2.6.8.1/arch/ia64/configs/generic_defconfig linux-2.6.8.1-no-BLK_DEV_ADMA/arch/ia64/configs/generic_defconfig
@@ -207,7 +207,6 @@
 # CONFIG_BLK_DEV_IDEDMA_FORCED is not set
 CONFIG_IDEDMA_PCI_AUTO=y
 # CONFIG_IDEDMA_ONLYDISK is not set
-CONFIG_BLK_DEV_ADMA=y
 # CONFIG_BLK_DEV_AEC62XX is not set
 # CONFIG_BLK_DEV_ALI15X3 is not set
 # CONFIG_BLK_DEV_AMD74XX is not set
arch/ia64/configs/sn2_defconfig +0 -1
diff -Nur linux-2.6.8.1/arch/ia64/configs/sn2_defconfig linux-2.6.8.1-no-BLK_DEV_ADMA/arch/ia64/configs/sn2_defconfig
@@ -206,7 +206,6 @@
 # CONFIG_BLK_DEV_IDEDMA_FORCED is not set
 CONFIG_IDEDMA_PCI_AUTO=y
 # CONFIG_IDEDMA_ONLYDISK is not set
-CONFIG_BLK_DEV_ADMA=y
 # CONFIG_BLK_DEV_AEC62XX is not set
 # CONFIG_BLK_DEV_ALI15X3 is not set
 # CONFIG_BLK_DEV_AMD74XX is not set
arch/ia64/configs/zx1_defconfig +0 -1
diff -Nur linux-2.6.8.1/arch/ia64/configs/zx1_defconfig linux-2.6.8.1-no-BLK_DEV_ADMA/arch/ia64/configs/zx1_defconfig
@@ -187,7 +187,6 @@
 CONFIG_BLK_DEV_IDEDMA_PCI=y
 # CONFIG_BLK_DEV_IDEDMA_FORCED is not set
 # CONFIG_IDEDMA_PCI_AUTO is not set
-CONFIG_BLK_DEV_ADMA=y
 # CONFIG_BLK_DEV_AEC62XX is not set
 # CONFIG_BLK_DEV_ALI15X3 is not set
 # CONFIG_BLK_DEV_AMD74XX is not set
arch/ia64/defconfig +0 -1
diff -Nur linux-2.6.8.1/arch/ia64/defconfig linux-2.6.8.1-no-BLK_DEV_ADMA/arch/ia64/defconfig
@@ -204,7 +204,6 @@
 # CONFIG_BLK_DEV_IDEDMA_FORCED is not set
 CONFIG_IDEDMA_PCI_AUTO=y
 # CONFIG_IDEDMA_ONLYDISK is not set
-CONFIG_BLK_DEV_ADMA=y
 # CONFIG_BLK_DEV_AEC62XX is not set
 # CONFIG_BLK_DEV_ALI15X3 is not set
 # CONFIG_BLK_DEV_AMD74XX is not set
arch/mips/configs/lasat200_defconfig +0 -1
diff -Nur linux-2.6.8.1/arch/mips/configs/lasat200_defconfig linux-2.6.8.1-no-BLK_DEV_ADMA/arch/mips/configs/lasat200_defconfig
@@ -266,7 +266,6 @@
 # CONFIG_BLK_DEV_IDEDMA_FORCED is not set
 CONFIG_IDEDMA_PCI_AUTO=y
 # CONFIG_IDEDMA_ONLYDISK is not set
-CONFIG_BLK_DEV_ADMA=y
 # CONFIG_BLK_DEV_AEC62XX is not set
 # CONFIG_BLK_DEV_ALI15X3 is not set
 # CONFIG_BLK_DEV_AMD74XX is not set
arch/mips/configs/pb1500_defconfig +0 -1
diff -Nur linux-2.6.8.1/arch/mips/configs/pb1500_defconfig linux-2.6.8.1-no-BLK_DEV_ADMA/arch/mips/configs/pb1500_defconfig
@@ -238,7 +238,6 @@
 CONFIG_BLK_DEV_IDEDMA_PCI=y
 # CONFIG_BLK_DEV_IDEDMA_FORCED is not set
 # CONFIG_IDEDMA_PCI_AUTO is not set
-CONFIG_BLK_DEV_ADMA=y
 # CONFIG_BLK_DEV_AEC62XX is not set
 # CONFIG_BLK_DEV_ALI15X3 is not set
 # CONFIG_BLK_DEV_AMD74XX is not set
arch/mips/configs/pb1550_defconfig +0 -1
diff -Nur linux-2.6.8.1/arch/mips/configs/pb1550_defconfig linux-2.6.8.1-no-BLK_DEV_ADMA/arch/mips/configs/pb1550_defconfig
@@ -237,7 +237,6 @@
 CONFIG_BLK_DEV_IDEDMA_PCI=y
 # CONFIG_BLK_DEV_IDEDMA_FORCED is not set
 # CONFIG_IDEDMA_PCI_AUTO is not set
-CONFIG_BLK_DEV_ADMA=y
 # CONFIG_BLK_DEV_AEC62XX is not set
 # CONFIG_BLK_DEV_ALI15X3 is not set
 # CONFIG_BLK_DEV_AMD74XX is not set
arch/parisc/configs/c3000_defconfig +0 -1
diff -Nur linux-2.6.8.1/arch/parisc/configs/c3000_defconfig linux-2.6.8.1-no-BLK_DEV_ADMA/arch/parisc/configs/c3000_defconfig
@@ -170,7 +170,6 @@
 CONFIG_BLK_DEV_IDEDMA_PCI=y
 # CONFIG_BLK_DEV_IDEDMA_FORCED is not set
 # CONFIG_IDEDMA_PCI_AUTO is not set
-CONFIG_BLK_DEV_ADMA=y
 # CONFIG_BLK_DEV_AEC62XX is not set
 # CONFIG_BLK_DEV_ALI15X3 is not set
 # CONFIG_BLK_DEV_AMD74XX is not set
arch/ppc/configs/common_defconfig +0 -1
diff -Nur linux-2.6.8.1/arch/ppc/configs/common_defconfig linux-2.6.8.1-no-BLK_DEV_ADMA/arch/ppc/configs/common_defconfig
@@ -215,7 +215,6 @@
 # CONFIG_BLK_DEV_IDEDMA_FORCED is not set
 CONFIG_IDEDMA_PCI_AUTO=y
 # CONFIG_IDEDMA_ONLYDISK is not set
-CONFIG_BLK_DEV_ADMA=y
 # CONFIG_BLK_DEV_AEC62XX is not set
 # CONFIG_BLK_DEV_ALI15X3 is not set
 # CONFIG_BLK_DEV_AMD74XX is not set
arch/ppc/configs/k2_defconfig +0 -1
diff -Nur linux-2.6.8.1/arch/ppc/configs/k2_defconfig linux-2.6.8.1-no-BLK_DEV_ADMA/arch/ppc/configs/k2_defconfig
@@ -191,7 +191,6 @@
 CONFIG_BLK_DEV_IDEDMA_PCI=y
 # CONFIG_BLK_DEV_IDEDMA_FORCED is not set
 # CONFIG_IDEDMA_PCI_AUTO is not set
-CONFIG_BLK_DEV_ADMA=y
 # CONFIG_BLK_DEV_AEC62XX is not set
 CONFIG_BLK_DEV_ALI15X3=y
 # CONFIG_WDC_ALI15X3 is not set
arch/ppc/configs/lopec_defconfig +0 -1
diff -Nur linux-2.6.8.1/arch/ppc/configs/lopec_defconfig linux-2.6.8.1-no-BLK_DEV_ADMA/arch/ppc/configs/lopec_defconfig
@@ -200,7 +200,6 @@
 # CONFIG_BLK_DEV_IDEDMA_FORCED is not set
 CONFIG_IDEDMA_PCI_AUTO=y
 # CONFIG_IDEDMA_ONLYDISK is not set
-CONFIG_BLK_DEV_ADMA=y
 # CONFIG_BLK_DEV_AEC62XX is not set
 # CONFIG_BLK_DEV_ALI15X3 is not set
 # CONFIG_BLK_DEV_AMD74XX is not set
arch/ppc/configs/mcpn765_defconfig +0 -1
diff -Nur linux-2.6.8.1/arch/ppc/configs/mcpn765_defconfig linux-2.6.8.1-no-BLK_DEV_ADMA/arch/ppc/configs/mcpn765_defconfig
@@ -181,7 +181,6 @@
 CONFIG_BLK_DEV_IDEDMA_PCI=y
 # CONFIG_BLK_DEV_IDEDMA_FORCED is not set
 # CONFIG_IDEDMA_PCI_AUTO is not set
-CONFIG_BLK_DEV_ADMA=y
 # CONFIG_BLK_DEV_AEC62XX is not set
 # CONFIG_BLK_DEV_ALI15X3 is not set
 # CONFIG_BLK_DEV_AMD74XX is not set
arch/ppc/configs/pmac_defconfig +0 -1
diff -Nur linux-2.6.8.1/arch/ppc/configs/pmac_defconfig linux-2.6.8.1-no-BLK_DEV_ADMA/arch/ppc/configs/pmac_defconfig
@@ -223,7 +223,6 @@
 # CONFIG_BLK_DEV_IDEDMA_FORCED is not set
 CONFIG_IDEDMA_PCI_AUTO=y
 # CONFIG_IDEDMA_ONLYDISK is not set
-CONFIG_BLK_DEV_ADMA=y
 # CONFIG_BLK_DEV_AEC62XX is not set
 # CONFIG_BLK_DEV_ALI15X3 is not set
 # CONFIG_BLK_DEV_AMD74XX is not set
arch/ppc/defconfig +0 -1
diff -Nur linux-2.6.8.1/arch/ppc/defconfig linux-2.6.8.1-no-BLK_DEV_ADMA/arch/ppc/defconfig
@@ -223,7 +223,6 @@
 # CONFIG_BLK_DEV_IDEDMA_FORCED is not set
 CONFIG_IDEDMA_PCI_AUTO=y
 # CONFIG_IDEDMA_ONLYDISK is not set
-CONFIG_BLK_DEV_ADMA=y
 # CONFIG_BLK_DEV_AEC62XX is not set
 # CONFIG_BLK_DEV_ALI15X3 is not set
 # CONFIG_BLK_DEV_AMD74XX is not set
arch/ppc64/configs/g5_defconfig +0 -1
diff -Nur linux-2.6.8.1/arch/ppc64/configs/g5_defconfig linux-2.6.8.1-no-BLK_DEV_ADMA/arch/ppc64/configs/g5_defconfig
@@ -170,7 +170,6 @@
 # CONFIG_BLK_DEV_IDEDMA_FORCED is not set
 CONFIG_IDEDMA_PCI_AUTO=y
 # CONFIG_IDEDMA_ONLYDISK is not set
-CONFIG_BLK_DEV_ADMA=y
 # CONFIG_BLK_DEV_AEC62XX is not set
 # CONFIG_BLK_DEV_ALI15X3 is not set
 # CONFIG_BLK_DEV_AMD74XX is not set
arch/ppc64/configs/pSeries_defconfig +0 -1
diff -Nur linux-2.6.8.1/arch/ppc64/configs/pSeries_defconfig linux-2.6.8.1-no-BLK_DEV_ADMA/arch/ppc64/configs/pSeries_defconfig
@@ -173,7 +173,6 @@
 # CONFIG_BLK_DEV_IDEDMA_FORCED is not set
 CONFIG_IDEDMA_PCI_AUTO=y
 # CONFIG_IDEDMA_ONLYDISK is not set
-CONFIG_BLK_DEV_ADMA=y
 # CONFIG_BLK_DEV_AEC62XX is not set
 # CONFIG_BLK_DEV_ALI15X3 is not set
 CONFIG_BLK_DEV_AMD74XX=y
arch/ppc64/defconfig +0 -1
diff -Nur linux-2.6.8.1/arch/ppc64/defconfig linux-2.6.8.1-no-BLK_DEV_ADMA/arch/ppc64/defconfig
@@ -173,7 +173,6 @@
 # CONFIG_BLK_DEV_IDEDMA_FORCED is not set
 CONFIG_IDEDMA_PCI_AUTO=y
 # CONFIG_IDEDMA_ONLYDISK is not set
-CONFIG_BLK_DEV_ADMA=y
 # CONFIG_BLK_DEV_AEC62XX is not set
 # CONFIG_BLK_DEV_ALI15X3 is not set
 CONFIG_BLK_DEV_AMD74XX=y
arch/sparc64/defconfig +0 -1
diff -Nur linux-2.6.8.1/arch/sparc64/defconfig linux-2.6.8.1-no-BLK_DEV_ADMA/arch/sparc64/defconfig
@@ -251,7 +251,6 @@
 # CONFIG_BLK_DEV_IDEDMA_FORCED is not set
 CONFIG_IDEDMA_PCI_AUTO=y
 CONFIG_IDEDMA_ONLYDISK=y
-CONFIG_BLK_DEV_ADMA=y
 # CONFIG_BLK_DEV_AEC62XX is not set
 CONFIG_BLK_DEV_ALI15X3=y
 # CONFIG_WDC_ALI15X3 is not set
arch/x86_64/defconfig +0 -1
diff -Nur linux-2.6.8.1/arch/x86_64/defconfig linux-2.6.8.1-no-BLK_DEV_ADMA/arch/x86_64/defconfig
@@ -212,7 +212,6 @@
 # CONFIG_BLK_DEV_IDEDMA_FORCED is not set
 CONFIG_IDEDMA_PCI_AUTO=y
 # CONFIG_IDEDMA_ONLYDISK is not set
-CONFIG_BLK_DEV_ADMA=y
 # CONFIG_BLK_DEV_AEC62XX is not set
 # CONFIG_BLK_DEV_ALI15X3 is not set
 CONFIG_BLK_DEV_AMD74XX=y
#2 lore raw

Re: [PATCH 2/2] ide: remove obsolete CONFIG_BLK_DEV_ADMA - cleanup arch

Quoted 3 lines · Raphael Zimmerer

Cleans up default config for various archs, removing CONFIG_BLK_DEV_IDEPCI

I don't see much point in applying global defconfig sweeps, really. There's no end to it.

Obsolete paremeters do no real harm, and arch maintainers will automatically eliminate obsolete stuff when they do their next defconfig update.

#3 lore raw

Re: [PATCH 2/2] ide: remove obsolete CONFIG_BLK_DEV_ADMA - cleanup arch

Quoted 6 lines · Andrew Morton

I don't see much point in applying global defconfig sweeps, really. There's no end to it.

Obsolete paremeters do no real harm, and arch maintainers will automatically eliminate obsolete stuff when they do their next defconfig update.

Okey, I see the point. So Part 2/2 of this Patch is obsolete.

- Raphael