Skip to contentSkip to conversation

Trivial warning fix patch

PATCH In review Pantelis Antoniou 2 participants 4 messages Sep 14, 2004 – Sep 15, 2004

lore
Share & tools
lore

Pantelis Antoniou

author
#0 lore raw

PATCH 1/1 Trivial warning fix patch

Hi

The following patch removes some annoying warnings produced by the latest gccs.

Regards

Pantelis

arch/ppc/lib/rheap.c +4 -4
diff -Nur --exclude=RCS --exclude=CVS --exclude=SCCS --exclude=BitKeeper --exclude=ChangeSet linuxppc_2.5/arch/ppc/lib/rheap.c linuxppc_2.5-intracom/arch/ppc/lib/rheap.c
@@ -216,7 +216,7 @@
 
 	/* Grow the after block backwards */
 	if (before == NULL && after != NULL) {
-		(int8_t *) after->start -= size;
+		after->start = (int8_t *)after->start - size;
 		after->size += size;
 		return;
 	}

@@ -407,7 +407,7 @@
 	/* blk still in free list, with updated start and/or size */
 	if (bs == s || be == e) {
 		if (bs == s)
-			(int8_t *) blk->start += size;
+			blk->start = (int8_t *)blk->start + size;
 		blk->size -= size;
 
 	} else {

@@ -471,7 +471,7 @@
 	newblk->owner = owner;
 
 	/* blk still in free list, with updated start, size */
-	(int8_t *) blk->start += size;
+	blk->start = (int8_t *)blk->start + size;
 	blk->size -= size;
 
 	start = newblk->start;

@@ -535,7 +535,7 @@
 	/* blk still in free list, with updated start and/or size */
 	if (bs == s || be == e) {
 		if (bs == s)
-			(int8_t *) blk->start += size;
+			blk->start = (int8_t *)blk->start + size;
 		blk->size -= size;
 
 	} else {
#1 lore raw
Quoted 4 lines · Pantelis Antoniou

Hi

The following patch removes some annoying warnings produced by the latest gccs.

Can you please read the Developer's Certificate of Origin 1.0 (found in Documentation/SubmittingPatches and add the approraite lines? Thanks (I hate to be annoying about it, but..)

Signature · 2 lines
Tom Rini
http://gate.crashing.org/~trini/
author
#2 lore raw
Quoted 5 lines · Tom Rini
Quoted 2 lines · Pantelis Antoniou

Hi

Quoted 8 lines
Quoted 2 lines

The following patch removes some annoying warnings produced by the latest gccs.

Can you please read the Developer's Certificate of Origin 1.0 (found in Documentation/SubmittingPatches and add the approraite lines? Thanks (I hate to be annoying about it, but..)

Signed-off-by Pantelis Antoniou <[email protected]>

Boy is this anal or what?

Regards

Pantelis

arch/ppc/lib/rheap.c +4 -4
diff -Nur --exclude=RCS --exclude=CVS --exclude=SCCS --exclude=BitKeeper --exclude=ChangeSet linuxppc_2.5/arch/ppc/lib/rheap.c linuxppc_2.5-intracom/arch/ppc/lib/rheap.c
@@ -216,7 +216,7 @@
 
 	/* Grow the after block backwards */
 	if (before == NULL && after != NULL) {
-		(int8_t *) after->start -= size;
+		after->start = (int8_t *)after->start - size;
 		after->size += size;
 		return;
 	}

@@ -407,7 +407,7 @@
 	/* blk still in free list, with updated start and/or size */
 	if (bs == s || be == e) {
 		if (bs == s)
-			(int8_t *) blk->start += size;
+			blk->start = (int8_t *)blk->start + size;
 		blk->size -= size;
 
 	} else {

@@ -471,7 +471,7 @@
 	newblk->owner = owner;
 
 	/* blk still in free list, with updated start, size */
-	(int8_t *) blk->start += size;
+	blk->start = (int8_t *)blk->start + size;
 	blk->size -= size;
 
 	start = newblk->start;

@@ -535,7 +535,7 @@
 	/* blk still in free list, with updated start and/or size */
 	if (bs == s || be == e) {
 		if (bs == s)
-			(int8_t *) blk->start += size;
+			blk->start = (int8_t *)blk->start + size;
 		blk->size -= size;
 
 	} else {
#3 lore raw
Quoted 10 lines · Pantelis Antoniou
Quoted 9 lines · Tom Rini
Quoted 4 lines · Pantelis Antoniou

Hi

The following patch removes some annoying warnings produced by the latest gccs.

Quoted 5 lines
Quoted 3 lines

Can you please read the Developer's Certificate of Origin 1.0 (found in Documentation/SubmittingPatches and add the approraite lines? Thanks (I hate to be annoying about it, but..)

Signed-off-by Pantelis Antoniou <[email protected]>

Thanks, I've tossed this into my tree to point Linus at.

Signature · 2 lines
Tom Rini
http://gate.crashing.org/~trini/