Skip to contentSkip to conversation

fbdev: rivafb I2C timings too fast

PATCH In review Antonino A. Daplas 2 participants 2 messages Sep 14, 2004 Framebuffer layer

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fbdev: rivafb I2C timings too fast

The timings in rivafb's i2c, although enough for EDID reading, are too fast for some user applications. Reported by Nicolas Boichat <[email protected]>.

This patch increases the timeouts.

---

 rivafb-i2c.c |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)
drivers/video/riva/rivafb-i2c.c +2 -3
diff -uprN linux-2.6.9-rc1-mm5-orig/drivers/video/riva/rivafb-i2c.c linux-2.6.9-rc1-mm5/drivers/video/riva/rivafb-i2c.c
@@ -105,9 +105,8 @@ static int riva_setup_i2c_bus(struct riv
 	chan->algo.setscl		= riva_gpio_setscl;
 	chan->algo.getsda		= riva_gpio_getsda;
 	chan->algo.getscl		= riva_gpio_getscl;
-	chan->algo.udelay		= 5;
-	chan->algo.mdelay               = 5;
-	chan->algo.timeout		= 10;
+	chan->algo.udelay		= 40;
+	chan->algo.timeout		= 20;
 	chan->algo.data 		= chan;
 
 	i2c_set_adapdata(&chan->adapter, chan);

-------------------------------------------------------
This SF.Net email is sponsored by: thawte's Crypto Challenge Vl Crack the code and win a Sony DCRHC40 MiniDV Digital Handycam Camcorder. More prizes in the weekly Lunch Hour Challenge. Sign up NOW http://ad.doubleclick.net/clk;10740251;10262165;m

#1 lore raw
Quoted 5 lines · Antonino A. Daplas

The timings in rivafb's i2c, although enough for EDID reading, are too fast for some user applications. Reported by Nicolas Boichat <[email protected]>.

This patch increases the timeouts.

Thank you.

Best regards,

Nicolas

-------------------------------------------------------
This SF.Net email is sponsored by: thawte's Crypto Challenge Vl Crack the code and win a Sony DCRHC40 MiniDV Digital Handycam Camcorder. More prizes in the weekly Lunch Hour Challenge. Sign up NOW http://ad.doubleclick.net/clk;10740251;10262165;m