Skip to contentSkip to conversation

cdrom/sonycd535: replace

PATCH New Nishanth Aravamudan 1 participant 1 message Sep 15, 2004 Kernel janitors

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 cdrom/sonycd535: replace

Any comments would be appreciated.

Description: Use msleep_interruptible() instead of schedule_timeout() to gurantee the task delays as expected.

drivers/cdrom/sonycd535.c +2 -2
@@ -129,6 +129,7 @@
 #include <linux/mm.h>
 #include <linux/slab.h>
 #include <linux/init.h>
+#include <linux/delay.h>
 
 #define REALLY_SLOW_IO
 #include <asm/system.h>
@@ -1478,8 +1479,7 @@ static int __init sony535_init(void)
 	/* look for the CD-ROM, follows the procedure in the DOS driver */
 	inb(select_unit_reg);
 	/* wait for 40 18 Hz ticks (reverse-engineered from DOS driver) */
-	set_current_state(TASK_INTERRUPTIBLE);
-	schedule_timeout((HZ+17)*40/18);
+	msleep_interruptible(2223);
 	inb(result_reg);
 
 	outb(0, read_status_reg);	/* does a reset? */

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors