char/generic_serial:
Subsystems (2)
PATCH 9/33 char/generic_serial:
Any comments would be appreciated.
Description: Use msleep_interruptible() instead of schedule_timeout() to guarantee the task delays as expected.
Signed-off-by Nishanth Aravamudan <[email protected]>
drivers/char/generic_serial.c +3 -4
@@ -26,6 +26,7 @@#include <linux/mm.h> #include <linux/generic_serial.h> #include <linux/interrupt.h> +#include <linux/delay.h> #include <asm/semaphore.h> #include <asm/uaccess.h>
@@ -399,8 +400,7 @@ static int gs_wait_tx_flushed (void * ptgs_dprintk (GS_DEBUG_FLUSH ,"Expect to finish in %d jiffies " "(%d chars).\n" , jiffies_to_transmit, charsleft); -set_current_state (TASK_INTERRUPTIBLE ); -schedule_timeout (jiffies_to_transmit); +msleep_interruptible (jiffies_to_msecs (jiffies_to_transmit));if (signal_pending (current)) {gs_dprintk (GS_DEBUG_FLUSH ,"Signal pending. Bombing out: " ); rv = -EINTR ;
@@ -771,8 +771,7 @@ void gs_close(struct tty_struct * tty, sif (port->blocked_open) {if (port->close_delay) { -set_current_state (TASK_INTERRUPTIBLE ); -schedule_timeout (port->close_delay); +msleep_interruptible (jiffies_to_msecs (port->close_delay)); }wake_up_interruptible (&port->open_wait); }
_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors