char/zftape-buffers:
Subsystems (2)
PATCH 32/33 char/zftape-buffers:
Any comments would be appreciated. There actually won't be a PATCH 33/33, because I dropped one that even I wouldn't approve :)
Description: Use msleep_interruptible() instead of schedule_timeout() to guarantee the task delays as expected.
drivers/char/ftape/zftape/zftape-buffers.c +2 -2
@@ -27,6 +27,7 @@#include <linux/errno.h> #include <linux/mm.h> #include <linux/slab.h> +#include <linux/delay.h> #include <linux/zftape.h>
@@ -119,8 +120,7 @@ void *zft_kmalloc(size_t size)void *new;while ((new =kmalloc (size,GFP_KERNEL )) ==NULL ) { - current->state =TASK_INTERRUPTIBLE ; -schedule_timeout (HZ /10 ); +msleep_interuptible (100 ); }memset (new,0 , size); used_memory += size;
_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors
Quoted 19 lines · Nishanth Aravamudan
Any comments would be appreciated. There actually won't be a PATCH 33/33, because I dropped one that even I wouldn't approve :)
Description: Use
msleep_interruptible()instead ofschedule_timeout()to guarantee the task delays as expected.Signed-off-by Nishanth Aravamudan <[email protected]>drivers/char/ftape/zftape/zftape-buffers.c +1
-0@@ -27,6 +27,7 @@#include <linux/errno.h> #include <linux/mm.h> #include <linux/slab.h> +#include <linux/delay.h> #include <linux/zftape.h>
drivers/char/ftape/zftape/zftape-buffers.c void *zft_kmalloc(size_t size) · line 123
Quoted 6 lines
drivers/char/ftape/zftape/zftape-buffers.c +1
-2@@ -119,8 +120,7 @@ void *zft_kmalloc(size_t size)void *new;while ((new =kmalloc (size,GFP_KERNEL )) ==NULL ) { - current->state =TASK_INTERRUPTIBLE ; -schedule_timeout (HZ /10 ); +msleep_interuptible (100 );
^
hmm strange function you are referencing ;)
grep says it's the only case of this typo.
fixed in kjt.
drivers/char/ftape/zftape/zftape-buffers.c void *zft_kmalloc(size_t size) · line 126
Quoted 3 lines
drivers/char/ftape/zftape/zftape-buffers.c +0
-0}memset (new,0 , size); used_memory += size;
a++ maks
_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors