isdn/hysdn_sched: replace
PATCH 10/15 isdn/hysdn_sched: replace
Any comments would be appreciated. This is a re-push of a patch submitted a few months ago which has not been merged as of 2.6.9-rc1-mm5 / 2.6.9-rc2.
Description: Use msleep_interruptible() instead of schedule_timeout() to guarantee the task delays as expected.
Signed-off-by Nishanth Aravamudan <[email protected]>
drivers/isdn/hysdn/hysdn_sched.c +3 -4
@@ -17,6 +17,7 @@#include <linux/kernel.h> #include <linux/ioport.h> #include <linux/interrupt.h> +#include <linux/delay.h> #include <asm/io.h> #include "hysdn_defs.h"
@@ -160,8 +161,7 @@ hysdn_tx_cfgline(hysdn_card * card, uchaif (card->debug_flags &LOG_SCHED_ASYN )hysdn_addlog (card,"async tx-cfg delayed" ); -set_current_state (TASK_INTERRUPTIBLE ); -schedule_timeout ((20 *HZ ) /1000 );/* Timeout 20ms */ +msleep_interruptible (20 );/* Timeout 20ms */ if (!--cnt) {restore_flags (flags);return (-ERR_ASYNC_TIME );/* timed out */
@@ -190,8 +190,7 @@ hysdn_tx_cfgline(hysdn_card * card, uchaif (card->debug_flags &LOG_SCHED_ASYN )hysdn_addlog (card,"async tx-cfg waiting for tx-ready" ); -set_current_state (TASK_INTERRUPTIBLE ); -schedule_timeout ((20 *HZ ) /1000 );/* Timeout 20ms */ +msleep_interruptible (20 );/* Timeout 20ms */ if (!--cnt) {restore_flags (flags);return (-ERR_ASYNC_TIME );/* timed out */
_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors